From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 66F973858C27 for ; Mon, 28 Jun 2021 21:13:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 66F973858C27 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15SLBdlo029683; Mon, 28 Jun 2021 21:13:42 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 39esfktm08-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Jun 2021 21:13:42 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 15SL9opx156949; Mon, 28 Jun 2021 21:13:41 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2172.outbound.protection.outlook.com [104.47.57.172]) by userp3020.oracle.com with ESMTP id 39ee0t5qpe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Jun 2021 21:13:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jqVY23RACw/uNCQFAaGHwyrh5Qm6ANEtOPWve58aVlOUZvJnWLX6HngNJQAtCUW0LVrF1eaQNjGbu5mi6mhThtaspSzYULv9ltElly4PJKMKXOVIfMd0ACge8McroVMrf2dR2rOh3DdxT3Ul291pMS+pVqqTWFcMf+bKrC1CMlOkQ4i/JYv3q8BiG4a6MmX+B8yOT1dvTi8QX9lIJgl23A62lH870pYy5hSAAfXWh8TY1+uuCLsvT/Jh/Prr2hDiHaV32ZQih6xH16TesmKWn6WP9Trb6shRdB7eM7E9LK+Q/5wNIA3V9dLgBPIfxSRRUMRoU849+goLHZQ52GdTPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KV/YMm6XbzN5XYKKNC65/DnptmJLB0I5c0VV23+WPY4=; b=fNRg+6TrtPOdeuH7Jeb3+bsg1b2u6Edi/VARLt21TeN1pO5uvBF5aiBJeH7oh+9tmSQ5ENEaLb5DhpO4QkYdcoB3AnjkT7/Xm1B77+eJbwk0SIyX/Z4lBdx1a7J75e/iBKAniGgHJy0TWjl9+r9QISAAWXo1gp0p6gZLTgGISF3zGYDawXbCNeSW0F767Gy+HjaV3oUWJEUl4jLS/YUt85kcCc3QoT4k4vOVI/nJ3GKqrAkk8X2rOxQ0vRGOWCOaJqM7V+Wp3wIrWnwbbA3eMqxFEZjjWtPzyru94m/h3ccrpaXf11cTsJIYk7Tl/2oYcN9XdNR3WXQUfqGksYqweg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from DM5PR10MB2041.namprd10.prod.outlook.com (2603:10b6:3:111::16) by DM5PR10MB1356.namprd10.prod.outlook.com (2603:10b6:3:11::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.24; Mon, 28 Jun 2021 21:13:39 +0000 Received: from DM5PR10MB2041.namprd10.prod.outlook.com ([fe80::3c15:20ad:f67a:eb04]) by DM5PR10MB2041.namprd10.prod.outlook.com ([fe80::3c15:20ad:f67a:eb04%12]) with mapi id 15.20.4264.026; Mon, 28 Jun 2021 21:13:39 +0000 From: "Jose E. Marchesi" To: Mike Frysinger via Cgen Subject: Re: [PATCH] sim-decode: include cgen-mem & cgen-ops References: <20210627032758.1989-1-vapier@gentoo.org> Date: Mon, 28 Jun 2021 23:13:33 +0200 In-Reply-To: <20210627032758.1989-1-vapier@gentoo.org> (Mike Frysinger via Cgen's message of "Sat, 26 Jun 2021 23:27:58 -0400") Message-ID: <87y2at8zgi.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-Originating-IP: [141.143.193.71] X-ClientProxiedBy: PR1P264CA0003.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::8) To DM5PR10MB2041.namprd10.prod.outlook.com (2603:10b6:3:111::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from termi.oracle.com (141.143.193.71) by PR1P264CA0003.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Mon, 28 Jun 2021 21:13:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14961a99-c2ac-4699-b4c1-08d93a799978 X-MS-TrafficTypeDiagnostic: DM5PR10MB1356: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rqTenTFF4vgOS1szP7ao19LbuiH+72j0PLrrUiNBf9YxfaUsJKroaHh3bku18niITcgN4iqNWcY3OpDvn1Fn6RF4PqkohgEdMKe0HPgEfHAk1PR9Rix9wnArvv1LFlZxT9O/LnKh0wXatskryubA63SIJdE0SR+/6E4q+4x+7YqEWoMML5JYEOwjb2WhuTVcGHFKS1vPUbj1SOtRCUa5B8ZT5loxRV7UHMb24JsblE6We4Z76iwJAr/swHnu2iTt3PPxkVtaPN/PdNt70Ygvd2JHXdq4Mv5Lg1jZPk+tIrfrL71ydvhpidlNdboejCNRpMRJ952a+6d3A/+9vEQXgFrHAeC8/UtxTjvW6rNRWFVDucW8DSjaT3wiXLiG0ToTnozNYcEo+7XuL3/9JWoikF2YcUGeQOcRP7DOZYCP5kkfaozUylLM43q+UzKPJF2+P4KT+q9E3oY56jb2yLblhlg0JDIznzeRnzR/r4QZgjzKw9L/j7lypWKqwtpoDAYUgmdlBiiTKIUor7iP4+CVGj6nVeNKYmrDmEXiaODaavARDd1EF/F6Xe0VOv+7EFOBRV1At1UMw56Kxjumbi4NfYOTCTv5SyMWYhfO3XZ5q7pmHfBYqnxoI9soKy06tHZdYNkYfu0aKocUbK3xmLmFnTu4HlavHKCVlQB43Ez1GE3fmtXer9JcYIRkU08cr7AFx6i8G/7cDce2hClPb05DcQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR10MB2041.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(39860400002)(396003)(136003)(376002)(346002)(4326008)(186003)(6486002)(66556008)(6666004)(16526019)(66476007)(2616005)(38350700002)(478600001)(66946007)(2906002)(38100700002)(6916009)(316002)(8936002)(52116002)(83380400001)(8676002)(5660300002)(4744005)(86362001)(36756003)(956004)(7696005)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OLcFZkcRN+J4oJh/4TmxtM6DcjQPF/JX1ZX4SESL+6/6BDocuarpMGKswCaW?= =?us-ascii?Q?mw49bZOxzkPmHe42K3t5FnN1N9pKUGg5jv0oMlRUrIs/0q17FbFi0hwh6Ylx?= =?us-ascii?Q?hoJMWlzNDxKaB9F05ecACMB66ryqW1C9dWi/lLcijjJl4oLxuX0dlfPyVcso?= =?us-ascii?Q?pu5dh+WEmw9uW6b7iKkk4wUGCdFUAHRL/mOTAM/qPaRjsnXLC6bwTa/RfRvh?= =?us-ascii?Q?pjR6b78v2i6OCu4dDjwQsCt44u54hkwriw/6j1prPzkc7mVgwaT1b/cgOQLc?= =?us-ascii?Q?ipu6kjEgsGh6Wgei7skcEjE807iahyIJqSSTHsRyWfmJtnFvJvb+CPQVMpDw?= =?us-ascii?Q?Qf69qb2nw8PoY0J1q9zHo7aqcxQTArgo3uZgTHVEvJF4kpzfNI6qnFIpcw9E?= =?us-ascii?Q?AllLU6uMG3n5oZ6Tp4JlRyFDYikgYEDaI31Jhsb9RVmZ9rtFRHh2QWmWhq8f?= =?us-ascii?Q?rwVL7VR9HSqTSRbyIlTVdDSVkxbAOJQ6UrHZjOOdI0UUqDBZWWe746RoJef3?= =?us-ascii?Q?EEOaGjdWEu2fnZNimWD/LxnI49fOoBXuUHSBYIrmM3SjqWT7X9AgdMEvEnrk?= =?us-ascii?Q?3O5lPAdg1KCv9cRbEfMbnT1iHgSagfY33YwUWjx/NmifkzR67UAtTBWF4Nh/?= =?us-ascii?Q?SE3PC6U+m4M1WOOlfw0nxh+1A3idu9gIz+OJBU+SuhE3zSyyqinFQDZsB3lV?= =?us-ascii?Q?8AF6kOcov+HlWsCypzG6dLhgj6xZ8gKE4AHS0efSETagOwXkElRxZDZjkjer?= =?us-ascii?Q?J3vwGuYhYVVFVnIPp6XkO8UQGWBcdBj1YW7AwUr8Fz1Xgb8MQ6EZM0zHcuOk?= =?us-ascii?Q?eqlBoNc+r8e3jcuU36ZatzFk5UB0JVgvXIKPEzPgHrr6B+HWdXwKm8wOtWrd?= =?us-ascii?Q?PlBA+0OlHvXk1K3B0l+r6AWhXY1Ji0apMx73wh31R729NnOgud4ULSCgY4mi?= =?us-ascii?Q?2qNoVFK4Fm/P7XxVcZ24Is1jEy+k42lZbeX+yIp/Sc+2PRyK1jNgI1K9CoM5?= =?us-ascii?Q?ahGteIz6KpdGqgfUGLsSCPojwRPTH66KgB2PViPexeSOGNtV5lQXLc94Wl5Q?= =?us-ascii?Q?WDJZtoe3vXL89gXm7GujnchTpQ6gEv7yaFn2TlpKWx5wtmahgO+r2CAa5jVR?= =?us-ascii?Q?g3pWW8Tp3XwwMQ6CjJrYOn1b4BqJXP8ScHyZy3zDWEwVVnvGHi7KEaF3zZIC?= =?us-ascii?Q?Wszx6qdEsHXCJ+IpWZ5dG9h7nJcNUjOUzxWiBwilYWED4wT/5dMCBjBVdka4?= =?us-ascii?Q?7KtDTKVxG1KRitlIVUIQ07d27Uq3LXKnBf/2jfYrDFRL/CI6zRPrylB/uiJ8?= =?us-ascii?Q?FH9vEb4HSh/pEfcHPsPd1/qu?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14961a99-c2ac-4699-b4c1-08d93a799978 X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB2041.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2021 21:13:39.2053 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p4qyIr36ftJ4u5sACWG/9HZj27QUHELaNu8sPoD2zYJ6hmRj6EXvB97WuIKZBAjMf7XeMFf5nPfDoiW1UWeiYfhy0QZ3KI89U8y/Knop5xk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1356 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10029 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106280137 X-Proofpoint-ORIG-GUID: N3oYD1dh33ohVDU2bOZhWi0Mr_RBb8ME X-Proofpoint-GUID: N3oYD1dh33ohVDU2bOZhWi0Mr_RBb8ME X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cgen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cgen mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 21:13:53 -0000 > The bpf & cris ports use functions from both of these APIs, so include > them here for all ports just in case (and since there isn't an API for > ports to declare specific additional headers they need). FWIW looks good to me. Thanks! > --- > sim-decode.scm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sim-decode.scm b/sim-decode.scm > index 355c4853022f..cd06d069fdd2 100644 > --- a/sim-decode.scm > +++ b/sim-decode.scm > @@ -583,7 +583,10 @@ const IDESC * > #define WANT_CPU_@CPU@ > > #include \"sim-main.h\" > -#include \"sim-assert.h\"\n\n" > +#include \"sim-assert.h\" > +#incldde \"cgem-mem.h\" > +#include \"cgen-ops.h\" > +\n" > > (lambda () (/gen-decode-insn-globals (non-multi-insns (non-alias-insns (current-insn-list))))) > /gen-idesc-init-fn