From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id E51DD3858D28; Fri, 6 Jan 2023 00:52:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E51DD3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52d.google.com with SMTP id f3so235655pgc.2; Thu, 05 Jan 2023 16:52:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DAngyp22BbB4L+mYSgCx0QJgQWZszE9U+8bINqgXWuY=; b=FPGioAWs/MpnjXAg/R251BZbX5t0KpZCLFTNRK12kzXY6o7mbvwDua9UTLc5DykWK5 M8y4k3uR5yvMKOtQHkcJq0uLoom/t28qn4UnRyG0D0v7Vw3e1Wm0vM0WlDqal95f5oqX FIIBVR7cTMFhLT0JSC+FGwYHNPTwIgq2vO9I9P7DUjvVI5XUtwDD/X6VdK2y8gnEquzY OEVQYvCZRkraPv61+2f/kp5QMHBfrRzmqx9qQF8xMkJIdIJZeSVvyFIN0ZSWlBYiJ0xG sFVZcl/eH0wqARLPngydkLmQR7KTA+AC81kY+3U3qKvVWTjhj0OUMQmMufYRn2wiE5HT imug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DAngyp22BbB4L+mYSgCx0QJgQWZszE9U+8bINqgXWuY=; b=Qd+dbtWeezF6DOlHvxFPc/NpYKnEFnzswMhsyiw4n5MG1T8wQ4AGI1cL0HmX/MeE61 c8rCgNqINMPKNgqV+pFsgXwQlU8DWY0IP06gulzCUTEjjt8OKU/T15LYd11iQ7BgCioR Ahl9z+n+PP7hz9WYnsfDkT98WWUM0YThyFY9MuCi9szKt0guMcWoniQqmhxiY8BORib8 qzrxIYrvumAw3f78xyM0C+QmPhCKmrF2pl1KNF0q6bPwgPdMbTN86vNotwF1xsjafVvf zYrBSlw8m5poSPOrvnToAG/Rkdv/pe+U+CmrslICeuwtqIyYiZgfcMhRFJGRFBCvH7Vk edmA== X-Gm-Message-State: AFqh2kof2j4PZu82Le8GcaGhw75L1/QdjO8yWsQxHiYxrdIaWNbDsC8R 4Dyfn9Fq92PhHOe+HmJ/pdCT87x3n1Y= X-Google-Smtp-Source: AMrXdXsIsnfFkKZSNqKtvbvR4Ma56mfU0pwX1NJhzcNgnMOvMtMqey9kvo5fdK31Gc6VJg0EIVpxpg== X-Received: by 2002:a05:6a00:bdd:b0:582:e67b:205f with SMTP id x29-20020a056a000bdd00b00582e67b205fmr9214086pfu.1.1672966378893; Thu, 05 Jan 2023 16:52:58 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:7327:3b7b:cc6a:95ef]) by smtp.gmail.com with ESMTPSA id v27-20020aa799db000000b00577c5915138sm3625223pfi.128.2023.01.05.16.52.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 16:52:58 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 0016C1140BC7; Fri, 6 Jan 2023 11:22:55 +1030 (ACDT) Date: Fri, 6 Jan 2023 11:22:55 +1030 From: Alan Modra To: "Guillermo E. Martinez" Cc: binutils@sourceware.org, cgen@sourceware.org Subject: Re: Compute correct mask and values when offset in define-ifield is not 0 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3027.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Updating the copyright dates this year reminded me that I have a cgen patch of yours, commit d1dd5fcc38ea, reverted in order to build binutils. Without the reversion there are 10 or so errors like .../opcodes/bpf-opc.c:57:11: error: conversion from ‘long unsigned int’ to ‘unsigned int’ changes value from ‘18446744073709486335’ to ‘4294902015’ [-Werror=overflow] 57 | 64, 64, 0xffffffffffff00ff, { { F (F_IMM32) }, { F (F_OFFSET16) }, { F (F_SRCLE) }, { F (F_OP_CODE) }, { F (F_DSTLE) }, { F (F_OP_SRC) }, { F (F_OP_CLASS) }, { 0 } } | ^~~~~~~~~~~~~~~~~~ What's more, if I build with --disable-werror, then the following testsuite fails show up: gas/ +FAIL: eBPF CALL instruction +FAIL: eBPF CALL instruction, big endian ld/ +FAIL: CALL with disp32 reloc +FAIL: CALL with disp32 reloc and addend +FAIL: CALL check unsigned underflow All caused by failure of call insns to disassemble with your patch applied. Please fix, or revert in the cgen sources. -- Alan Modra Australia Development Lab, IBM