From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id 8E40F3847825
 for <cgen@sourceware.org>; Tue, 29 Jun 2021 01:50:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E40F3847825
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id B215A335CD4;
 Tue, 29 Jun 2021 01:50:12 +0000 (UTC)
Date: Mon, 28 Jun 2021 21:50:11 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: Mike Frysinger via Cgen <cgen@sourceware.org>
Subject: Re: [PATCH] sim-decode: include cgen-mem & cgen-ops
Message-ID: <YNp8U3CgjT2fw83c@vapier>
Mail-Followup-To: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
 Mike Frysinger via Cgen <cgen@sourceware.org>
References: <20210627032758.1989-1-vapier@gentoo.org>
 <87y2at8zgi.fsf@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <87y2at8zgi.fsf@oracle.com>
X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: cgen@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cgen mailing list <cgen.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/cgen>,
 <mailto:cgen-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/cgen/>
List-Post: <mailto:cgen@sourceware.org>
List-Help: <mailto:cgen-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/cgen>,
 <mailto:cgen-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jun 2021 01:50:14 -0000

On 28 Jun 2021 23:13, Jose E. Marchesi wrote:
> > The bpf & cris ports use functions from both of these APIs, so include
> > them here for all ports just in case (and since there isn't an API for
> > ports to declare specific additional headers they need).
> 
> FWIW looks good to me.
> Thanks!
> 
> > ---
> >  sim-decode.scm | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/sim-decode.scm b/sim-decode.scm
> > index 355c4853022f..cd06d069fdd2 100644
> > --- a/sim-decode.scm
> > +++ b/sim-decode.scm
> > @@ -583,7 +583,10 @@ const IDESC *
> >  #define WANT_CPU_@CPU@
> >  
> >  #include \"sim-main.h\"
> > -#include \"sim-assert.h\"\n\n"
> > +#include \"sim-assert.h\"
> > +#incldde \"cgem-mem.h\"

i managed to have 2 typos in this line.
i fixed them after testing & before pushing :).
-mike