crash when displaying usage

crash when displaying usage

[Mike Frysinger]

disclaimer: i avoid lisp in general, so i don't have much to offer.

NB: i have to use a manual compile of guile-1.8 because cgen itself doesn't
support guile-2 (syntax errors).  i'm not sure if that's the cause, or if
there's something else.

in the current cgen checkout, printing the usage info always crashes.
$ guile-1.8 -l ./guile.scm -s ./cgen-sim.scm -s . --help

Backtrace:
In ././read.scm:
1145:  0* [string-append "
" "                    " #f]
In unknown file:
   ?:  1* [#<procedure #f (text)> #f]
In ././read.scm:
1144:  2* [map #<procedure #f (text)> (#f #<procedure #f (arg)>)]
1143:  3* [apply #<primitive-procedure string-append> ...
1136:  4* [string-append "-A file         " "  - " "generate arch.h in <file>" ...
1136:  5* [display ...
In unknown file:
   ?:  6* [#<procedure #f (arg)> ("-A" "file" "generate arch.h in <file>" ...)]
In ././read.scm:
1135:  7* [for-each #<procedure #f (arg)> (# # # # ...)]
1128:  8  (let* ((cep (current-error-port))) (case errtype ((help) #f) ...) ...)
1334:  9  [cgen-usage help "" ...]
1314: 10  (cond (# #) (# #) (# #) ...)
1309: 11* (case opt ((#f) (set! moreopts? #f)) ...)
1306: 12  (let* ((new-argv #) (opt #) (arg #)) (case opt (# #) ...) ...)
1377: 13  [loop ("--help")]
1377: 14  (if moreopts? (loop (cdr new-argv)))
1306: 15  (let* ((new-argv #) (opt #) (arg #)) (case opt (# #) ...) ...)
1305: 16* [loop ("-s" "." "--help")]
1289: 17  (let (# # # # ...) (# #) (cgen-call-with-debugging debugging #))
1257: 18* (let (# # # # ...) (# args) (let # # #))

cgen -s ./cgen-sim.scm -s . --help 
Usage: cgen arguments ...
-a arch-file      - specify path of .cpu file to load
-b                - use debugging evaluator, for backtraces
-d                - start interactive debugging session
-f flags          - specify a set of flags to control code generation
-h                - print usage information
--help            - print usage information
-i isa-list       - specify isa-list entries to keep
-m mach-list      - specify mach-list entries to keep
-s srcdir         - set srcdir
-t trace-options  - specify list of things to trace
                    Options:
                    commands - trace cgen commands (e.g. define-insn)
                    pmacros  - trace pmacro expansion
                    all      - trace everything
-v                - increment verbosity level
-w diagnostic-options  - specify list of things to issue diagnostics about
                    Options:
                    iformat - verify instruction formats are valid
                    all     - turn on all diagnostics
--version         - print version info
ERROR: In procedure string-append:
ERROR: Wrong type (expecting string): #f