From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id CBA5B3858D39 for ; Sun, 14 Nov 2021 18:13:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBA5B3858D39 Received: by smtp.gentoo.org (Postfix, from userid 559) id AB91734341A; Sun, 14 Nov 2021 18:13:49 +0000 (UTC) Date: Sun, 14 Nov 2021 13:13:54 -0500 From: Mike Frysinger To: Sergei Trofimovich Cc: cgen@sourceware.org, Sergei Trofimovich Subject: Re: [PATCH] cr16: fix build on gcc-12 (NULL comparison) Message-ID: Mail-Followup-To: Sergei Trofimovich , cgen@sourceware.org, Sergei Trofimovich References: <20211114174241.2955314-1-slyich@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xWhp0USST9ZHJgrB" Content-Disposition: inline In-Reply-To: <20211114174241.2955314-1-slyich@gmail.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cgen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cgen mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Nov 2021 18:13:52 -0000 --xWhp0USST9ZHJgrB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 14 Nov 2021 17:42, Sergei Trofimovich via Cgen wrote: > From: Sergei Trofimovich >=20 > On gcc-12 build fails as: >=20 > sim/cr16/interp.c: In function 'lookup_hash': > sim/cr16/interp.c:89:25: error: > the comparison will always evaluate as 'true' > for the address of 'mnimonic' will never be NULL [-Werror=3Daddress] > 89 | if ((h->ops->mnimonic !=3D NULL) && > | ^~ >=20 > 'mnimonic' is a sharr array within ops. It can never be NULL. >=20 > While at it renamed 'mnimonic' to 'mnemonic'. > --- > sim/cr16/cr16_sim.h | 2 +- > sim/cr16/interp.c | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) this code doesn't exist in cgen. did you mean to send the patch here ? -mike --xWhp0USST9ZHJgrB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmGRUeIACgkQQWM7n+g3 9YFWgxAAqXgKHhOaQQ1Xs+4ypCMm9pt7pCaB9tYmDZ31kiVul27KDTqbTNxzRX8P SMeH7L4mTLsv7GXwe8zbhflGpbfsV64sNqayS28y4zsJci8fSS8evpbmnBIxCLEg +SleuriSlYMpIbwTUs4e2svthO7dX9avXpfZku8jsuThKOIz8rZ58/kmWqauKqHq 8vQqteJsUR1IWOwHHCLTQc8pI6iw2uzPV0aDFa7Kjxh4C52186fCLo05Hd+lEgTt TtpbVIdfBgKcXpMrZPq02/UjddaBggCvDT7r5qEVu76Rh2Vm3XtxjC2V49XmutP1 sfhyAsM6u+Y2sc+dyN6/RzwzI7tTUNoupgUBtbEdmNQPLUFBuPpD9XM94QQx7EDI q91CKCTGsP+DBAYbKhLV0gFvhtkX+aeK1N8/yAbI+SxDR+4uenWjpwIj252PwFya J2ZVGfxe1E5/sDIDbW/8RMxLmxXwzflZi2KNFgX7sMNhCT4RaDkP2xgNrII2eoCh O7fvsG0ZK6FqN/xwNpzji/ImtaEM79QoJghsLL7BXI7QNidvSXqV4dgzOJozBADb PbmbVgE7O//smxS7rnt8YAYUblmaqIcnUPGXw1PFBKpuPIw3BdWQGj+CE6rsdahY TD4g+HuZYEjIUwW1gdfNrba/8rCm0ivhL9h46hI72pFOn4KqV6Q= =6EJb -----END PGP SIGNATURE----- --xWhp0USST9ZHJgrB--