From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=KSps=IB=gentoo.org=vapier@sourceware.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	by sourceware.org (Postfix) with ESMTP id 7B1DF3858D33
	for <cgen@sourceware.org>; Fri, 22 Dec 2023 19:55:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B1DF3858D33
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B1DF3858D33
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703274957; cv=none;
	b=xxBeCqT6R7reU/TVDqaWvq8crwX+VTNEBXyUn7/ecuKnmrL5Y4Z7MCgXXu8b2TsFCUD7YBxHWOcsI1OnSssex3IbEGMi8iVwwUgu65KwsS9PMFCL8PaTPqVJp/NAfEDaFQ/qeXfI3FXqWyVXYOiNe3OIZ5PvMofJlTDsP4E1DPs=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1703274957; c=relaxed/simple;
	bh=4XAql1uRHmZ1KuOu9/8EoSq0XHCa/VSrUfJrD6LVVsA=;
	h=Date:From:To:Subject:Message-ID:MIME-Version; b=ZV2VEhMxZBW1gTeH8m97XeQoaQ90Z+jYdWdLvwf7SlhaLnfXmaxUDQRNXkezg4HZJns469z6Cg9wrG3rsViZLfv/S4ObnxQEqPKZWz+o+x/nNHVMpJO60cvF3f32AiilbWi5mxUgbaO30knWqwCLF5oTKea5aiAAW2h/FvLIrTc=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: by smtp.gentoo.org (Postfix, from userid 559)
	id 2367F342FF8; Fri, 22 Dec 2023 19:55:56 +0000 (UTC)
Date: Fri, 22 Dec 2023 14:55:54 -0500
From: Mike Frysinger <vapier@gentoo.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: cgen@sourceware.org
Subject: Re: [PATCH] sim: tighten up generated decode tables
Message-ID: <ZYXpysSUEdzrPKRt@vapier>
References: <20231222010028.17297-1-vapier@gentoo.org>
 <20231222161209.GC29647@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Rm6jpZMsVxFyoxer"
Content-Disposition: inline
In-Reply-To: <20231222161209.GC29647@redhat.com>
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <cgen.sourceware.org>


--Rm6jpZMsVxFyoxer
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 22 Dec 2023 11:12, Frank Ch. Eigler wrote:
> > The use of /* fall through */ with consective case statements doesn't
> > really add any value, and when generating large files, can take up a
> > lot of space.  In the case of cris, it alone adds ~20k, or ~10%.
>=20
> A few kilobytes is basically zero cost, isn't it?

you're not necessarily wrong, although i find it easier to read without so
much noise.  i get that it's generated output, but when trying to debug and
understand the steps, having them be a bit readable is helpful.

i'll note that it's ~20k per file.  the sim tree has ~10 of these.  having
these seems like it adds up when using git as everyone has to carry the cos=
t.

it's possible to compress the code even further if i was able to figure out
how the lisp works.  we generate hundreds of case lines that could be shrunk
into 1.  things like:
          case 0:
          case 1:
          case 2:
          case 3:
          case 4:
          case 5:
          case 6:
          case 7:
          case 8:
          case 9:
          case 10:
          case 11:
          case 12:
          case 13:
          case 14: itype =3D CRISV10F_INSN_ADDOQ; goto extract_sfmt_addoq;
could be:
          case 0 ... 14: itype =3D CRISV10F_INSN_ADDOQ; goto extract_sfmt_a=
ddoq;

some switches have 0 ... 127.
-mike

--Rm6jpZMsVxFyoxer
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWF6coACgkQQWM7n+g3
9YGgYw/9GMl1Qy+1ERB/Rs+gp14eOVEckREiqH08Ga5WD8WXbhoGGM5/VMXQ7PPk
5yFmaI6t2NClQH86w4EdETWB0SIdXeiP45Ke7Ab7QzdcUnkj2EmF/uOjF1hbnQSX
lW6s+pwIr5OalFltkkQlHxgXE4FMrvUieCuGsPjAx+62vryjoFTdkElkJSbORtel
2Kn+4Z5ovc22bKbvJb9Pw0OH4PbID7FrI0pD2cEVw5aHruQ6QD5UEE48nDTYSSZL
+gImSEYKVg+R7AK/19XXH46EtkQDx4bGwLGZYM8zEbRPIQjNmRSbGSqR7GijYWE0
ahfIVY0IEveNBKQEoBaTGux29B/3G6ZzpW7X8cgr90kHhSQ5yR6V0LK/5jElci6E
fljRZeeJalpb65howHH/qmw/bKzGnb4vNgXXUCDA1VBuqVMI23lI9ubyNB2IhXmH
A/kbG8Z19gFMgeogu7J+lPS80XCHP1pxqKdpNHjetQJvnjJzZEd/aO/iNxQp9gf6
AZITPNwfF5D8Zr+VU7/YVxRwqyn8gQQmU49eM3HTYxPVB8EpsjQRcB1GYx0LAavP
PWtqvrpO5OZnrnowKkn+S/QOKLbxtocTXYwyqEUUTONeF3g4Pa5o6h3BJR4nGxST
u0hcOQ8dFmQTF1XVHFNCMwERPMiKQXDNT8k+zmW1eYrut0V8zu0=
=+7xj
-----END PGP SIGNATURE-----

--Rm6jpZMsVxFyoxer--