From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cgen-return-1813-listarch-cgen=sources.redhat.com@sources.redhat.com>
Received: (qmail 7487 invoked by alias); 14 Oct 2005 09:04:07 -0000
Mailing-List: contact cgen-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:cgen-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/cgen/>
List-Post: <mailto:cgen@sources.redhat.com>
List-Help: <mailto:cgen-help@sources.redhat.com>, <http://sources.redhat.com/lists.html#faqs>
Sender: cgen-owner@sources.redhat.com
Received: (qmail 7470 invoked by uid 22791); 14 Oct 2005 09:04:04 -0000
Received: from ns.suse.de (HELO mx1.suse.de) (195.135.220.2)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 14 Oct 2005 09:04:04 +0000
Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.suse.de (Postfix) with ESMTP id 608E8EEFF;
	Fri, 14 Oct 2005 11:04:01 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Kazuhiro Inaoka <inaoka.kazuhiro@renesas.com>
Cc: Nick Clifton <nickc@redhat.com>, binutils@sources.redhat.com,
	cgen@sources.redhat.com
Subject: Re: [PATCH] m32r-*-as  For a code depended for host word size.
References: <434F6596.404@renesas.com>
X-Yow: ..  I wonder if I ought to tell them about my PREVIOUS LIFE
 as a COMPLETE STRANGER?
Date: Fri, 14 Oct 2005 09:04:00 -0000
In-Reply-To: <434F6596.404@renesas.com> (Kazuhiro Inaoka's message of "Fri, 14
	Oct 2005 17:00:22 +0900")
Message-ID: <je4q7ko4g3.fsf@sykes.suse.de>
User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-SW-Source: 2005-q4/txt/msg00007.txt.bz2

Kazuhiro Inaoka <inaoka.kazuhiro@renesas.com> writes:

> 2005-10-14  Kazuhiro Inaoka <inaoka.kazuhiro@renesas.com>
>
>    * cpu/m32r.opc (parse_slo16): Changed for a code depended
>    for host word size.
> Index: m32r.opc
> ===================================================================
> RCS file: /cvs/src/src/cpu/m32r.opc,v
> retrieving revision 1.6
> diff -u -p -r1.6 m32r.opc
> --- m32r.opc	1 Jul 2005 11:16:30 -0000	1.6
> +++ m32r.opc	14 Oct 2005 07:33:21 -0000
> @@ -182,7 +182,7 @@ parse_slo16 (CGEN_CPU_DESC cd,
>          {
>  	  value &= 0xffff;
>            if (value & 0x8000)
> -             value |= 0xffff0000;
> +             value |= ~0xffff;

~0xffff is still 0xffff0000 for 32 bit ints and will be zero extended.
You probably want ~(bfd_vma)0xffff here.  Alternatively you can use

          value = ((value & 0xffff) ^ 0x8000) - 0x8000.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."