From: Nick Clifton <nickc@redhat.com>
To: cgen-mail@the-meissners.org
Cc: binutils@sources.redhat.com, cgen@sources.redhat.com
Subject: Re: Patches to move cgen files to C90 with prototypes
Date: Fri, 08 Aug 2003 08:18:00 -0000 [thread overview]
Message-ID: <m31xvwefkk.fsf@redhat.com> (raw)
In-Reply-To: <20030807004426.GA31603@tiktok.the-meissners.org> (Michael Meissner's message of "Wed, 6 Aug 2003 20:44:26 -0400")
Hi Michael, Hi Doug,
>> > 2003-08-06 Michael Meissner <gnu@the-meissners.org>
>> >
>> > ... massively large changelog entry,
>> > ... especially for just a k&r -> c90 substitution
>>
>> fwiw, I think people think they're under far too much pressure to
>> write anally correct changelog entries before a patch will get accepted.
>
> I don't care one way or another, as I can rewrite it however people want. I do
> recall it came up in GCC about a year ago, with people complaining that they
> wanted to be able to grep for each function modified, and in particular didn't
> want things like:
>
> * ({put,get}_some_function): Blah, blah, blah.
>
>> Nick, in this particular case, does one really have to mention every function?
>> How about this instead?
No I think that the functions should be mentioned.
I have objection to listing them together though, rather than one per
line. ie something like this would be OK:
* cgen-dis.in (print_normal): Remove PARAMS macro. Use void *
instead of PTR.
(print_address, print_keyword, print_insn_normal, print_insn,
default_print_insn, read_insn): Likewise.
(print_normal): Prototype definition. Use void * instead of PTR.
(print_address, print_keyword, print_insn_normal, read_insn,
print_insn, default_print_insn, print_insn_@arch@): Likewise.
(I prefer "likewise" to "ditto" but this is a personal thing).
Cheers
Nick
next prev parent reply other threads:[~2003-08-08 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-07 0:23 Michael Meissner
2003-08-07 0:44 ` Doug Evans
2003-08-07 13:52 ` Michael Meissner
2003-08-08 8:18 ` Nick Clifton [this message]
2003-08-08 11:49 ` Alan Modra
2003-08-08 12:15 ` Nick Clifton
2003-08-08 12:54 ` Frank Ch. Eigler
2003-08-08 13:07 ` Nick Clifton
2003-08-09 0:48 ` Alan Modra
2003-08-08 9:27 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31xvwefkk.fsf@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=cgen-mail@the-meissners.org \
--cc=cgen@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).