From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31189 invoked by alias); 17 Dec 2002 23:43:26 -0000 Mailing-List: contact cgen-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cgen-owner@sources.redhat.com Received: (qmail 31176 invoked from network); 17 Dec 2002 23:43:21 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by 209.249.29.67 with SMTP; 17 Dec 2002 23:43:21 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gBHNH0g11605 for ; Tue, 17 Dec 2002 18:17:00 -0500 Received: from hypatia.brisbane.redhat.com (IDENT:root@hypatia.brisbane.redhat.com [172.16.5.3]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBHNh7208419; Tue, 17 Dec 2002 18:43:07 -0500 Received: from scooby.brisbane.redhat.com (scooby.brisbane.redhat.com [172.16.5.228]) by hypatia.brisbane.redhat.com (8.11.6/8.11.6) with ESMTP id gBHNh5525721; Wed, 18 Dec 2002 09:43:06 +1000 Received: by scooby.brisbane.redhat.com (Postfix, from userid 500) id 23E0C15D; Tue, 17 Dec 2002 18:43:02 -0500 (EST) To: Doug Evans Cc: cgen@sources.redhat.com, hp@axis.com Subject: Re: m32r port breakage References: <200212100838.AAA12330@xris-athlon.transmeta.com> From: Ben Elliston Date: Tue, 17 Dec 2002 15:43:00 -0000 In-Reply-To: <200212100838.AAA12330@xris-athlon.transmeta.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-q4/txt/msg00103.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> Yes, it's been ages since I've looked at the m32r port, but Doug> it's the one I like to use when playing with things. Doug> Hans-Peter has a patch he wants to go in and before it has my Doug> blessing I want to play with it on a real port. Doug> This patch breaks the m32r simulator. Doug> 2001-04-02 Ben Elliston Doug> * sim-decode.scm (@prefix@_init_idesc_table): Compute tabsize Doug> using the size of the table and its elements. Doug> (-gen-decode-insn-globals): Define the idesc table's size to be Doug> the last instruction enum plus one, not @PREFIX@_INSN_MAX. Doug> * sim-model.scm (-gen-mach-defns): Define CPU_MAX_INSNS as the Doug> last instruction enum plus one, not @CPU@_INSN_MAX. Doug> Why was @PREFIX@_INSN_MAX replaced with "last instruction enum plus one"? A port I was doing had an instruction called "MAX" that generated the symbol @PREFIX@_INSN_MAX. Rather than change the name of the sentinel value, I decided to clean this up to avoid any further problems. I guess I got carried away. :-( Perhaps you could change the sentinel value's name to @PREFIX@_INSN__MAX? Ben