From mboxrd@z Thu Jan 1 00:00:00 1970 From: fche@redhat.com (Frank Ch. Eigler) To: greg@mcgary.org (Greg McGary) Cc: cgen@sourceware.cygnus.com Subject: Re: PATCH: string-expansion macros Date: Mon, 16 Apr 2001 12:37:00 -0000 Message-id: References: <200103022358.QAA31874.cygnus.local.cgen@kayak.mcgary.org> X-SW-Source: 2001-q2/msg00012.html greg@mcgary.org (Greg McGary) writes: : I have been sitting on this for almost 8 weeks now, waiting for some : spare time to submit it. [...] Likewise, to give feedback. :-( Overall, I like the extension. : [...] : I'd like to know why the old code tried to match macros before hard : insns? The reason I need to try hard insns before macros is that for : my MIPS-like port, string macros catch cases that can't be handled by : one insn, and implement a "virtual insn" that do things in 2 or 3 hard : insns. [...] Yes, this makes sense in most cases, but methinks there are other opposite cases also. It would be nice to control ordering preference by some attribute. The biggest part that bothers me is that conditional messing-about with the md_assemble function. Rather than call it recursively like this, I'd much rather see use of the gas sb (string-buffer) structure, and treatment as expanded gas macro bodies. - FChE