From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cgen-return-1635-listarch-cgen=sources.redhat.com@sources.redhat.com>
Received: (qmail 26287 invoked by alias); 16 Dec 2004 17:08:28 -0000
Mailing-List: contact cgen-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:cgen-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/cgen/>
List-Post: <mailto:cgen@sources.redhat.com>
List-Help: <mailto:cgen-help@sources.redhat.com>, <http://sources.redhat.com/lists.html#faqs>
Sender: cgen-owner@sources.redhat.com
Received: (qmail 26226 invoked from network); 16 Dec 2004 17:08:20 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 16 Dec 2004 17:08:20 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iBGH8Kdg021572
	for <cgen@sources.redhat.com>; Thu, 16 Dec 2004 12:08:20 -0500
Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBGH8Jr17410;
	Thu, 16 Dec 2004 12:08:19 -0500
To: cgen@sources.redhat.com
Subject: RFA: make parse-name handle lists containing symbols properly
From: Jim Blandy <jimb@redhat.com>
Date: Thu, 16 Dec 2004 17:08:00 -0000
Message-ID: <vt2ekhqnpf0.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-q4/txt/msg00025.txt.bz2


Not sure why the 1.6.4 porting work didn't catch this.

2004-12-13  Jim Blandy  <jimb@redhat.com>

	* utils-cgen.scm (parse-name): Don't assume that string-map can be
	applied to symbols.  Process everything as strings, and then
	convert to a symbol at the end.

Index: cgen/utils-cgen.scm
===================================================================
RCS file: /cvs/cvsfiles/devo/cgen/utils-cgen.scm,v
retrieving revision 1.61
diff -c -p -r1.61 utils-cgen.scm
*** cgen/utils-cgen.scm	20 Oct 2003 01:25:22 -0000	1.61
--- cgen/utils-cgen.scm	16 Dec 2004 17:05:38 -0000
***************
*** 175,185 ****
  ; FIXME: Isn't the plan to move ERRTXT to the 1st arg?
  
  (define (parse-name name errtxt)
!   (cond ((list? name)
! 	 (string->symbol (string-map (lambda (elm) (parse-name elm errtxt)) name)))
! 	((symbol? name) name)
! 	((string? name) (string->symbol name))
! 	(else (parse-error errtxt "improper name" name)))
  )
  
  ; Parse an object comment.
--- 175,187 ----
  ; FIXME: Isn't the plan to move ERRTXT to the 1st arg?
  
  (define (parse-name name errtxt)
!   (string->symbol
!    (let parse ((name name))
!      (cond
!       ((list? name) (string-map parse name))
!       ((symbol? name) (symbol->string name))
!       ((string? name) name)
!       (else (parse-error errtxt "improper name" name)))))
  )
  
  ; Parse an object comment.