From: fche@redhat.com (Frank Ch. Eigler)
To: Doug Evans <dje@sebabeach.org>
Cc: cgen@sourceware.org
Subject: Re: [patch] Hacky fix for -ve shifts in m32r decode2.c for cgen 1.1
Date: Sun, 12 Jul 2009 02:22:00 -0000 [thread overview]
Message-ID: <y0m4otiy70y.fsf@fche.csb> (raw)
In-Reply-To: <20090709214652.B5C876E3D1@sebabeach.org> (Doug Evans's message of "Thu, 9 Jul 2009 14:46:52 -0700 (PDT)")
Doug Evans <dje@sebabeach.org> writes:
> [...]
> Btw, has the sid m32r simulator been tested recently?
Not as far as I know.
> It's doing things like:
> m32rbf.cxx:
> else // pair of short instructions
> {
> UHI first = insn >> 16;
> sem->decode (this, pc, first, first);
> }
> and
> m32r-decode.cxx:
> unsigned int val = (((insn >> 24) & (15 << 4)) | ((insn >> 20) & (15 << 0)));
> switch (val)
> {
> case 0 :
> entire_insn = entire_insn >> 16;
>
> Note that
> - insn is being shifted by 16 tis and then by 24 bits,
Dunny, maybe this particular switch does not activate in the first
place for 16-bit short instructions?
> - after entire_insn >>= 16, it's been shifted by 32 bits.
(But is the value used after this point?)
- FChE
prev parent reply other threads:[~2009-07-12 2:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 21:47 Doug Evans
2009-07-12 2:22 ` Frank Ch. Eigler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y0m4otiy70y.fsf@fche.csb \
--to=fche@redhat.com \
--cc=cgen@sourceware.org \
--cc=dje@sebabeach.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).