From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1341 invoked by alias); 25 Jul 2006 13:58:17 -0000 Received: (qmail 1312 invoked by uid 9453); 25 Jul 2006 13:58:17 -0000 Date: Tue, 25 Jul 2006 13:58:00 -0000 Message-ID: <20060725135817.1311.qmail@sourceware.org> From: teigland@sourceware.org To: cluster-cvs@sources.redhat.com Subject: cluster/gfs2/mount mount.gfs2.c umount.gfs2.c Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2006-q3/txt/msg00191.txt.bz2 List-Id: CVSROOT: /cvs/cluster Module name: cluster Changes by: teigland@sourceware.org 2006-07-25 13:58:17 Modified files: gfs2/mount : mount.gfs2.c umount.gfs2.c Log message: From: fabbione@ubuntu.com This one was a nasty bug that was causing several issues. For example: mount -t gfs /dev/foo /mnt -> ok mount -t gfs /dev/foo /mnt/ -> nok failing with: can't find /proc/mounts entry for directory /mnt/ (caused by read_proc_mounts in util.c when comparing with /proc/mounts that does not reference the trailing /). Other bugs are also fixed by making mo->dir consistent. mount -t gfs /dev/foo /mnt -> ok umount /mnt/ -> nok: /sbin/umount.gfs: lock_dlm_leave: gfs_controld leave error: -1 because the mo->dir is also registered in lock_dlm daemon. This was causing a severe inconsistence that was blocking mounting/umounting or other volumes/devices. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs2/mount/mount.gfs2.c.diff?cvsroot=cluster&r1=1.14&r2=1.15 http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs2/mount/umount.gfs2.c.diff?cvsroot=cluster&r1=1.10&r2=1.11