From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29467 invoked by alias); 27 Jul 2006 23:11:56 -0000 Received: (qmail 29446 invoked by uid 9478); 27 Jul 2006 23:11:55 -0000 Date: Thu, 27 Jul 2006 23:11:00 -0000 Message-ID: <20060727231155.29445.qmail@sourceware.org> From: jbrassow@sourceware.org To: cluster-cvs@sources.redhat.com Subject: cluster/cmirror-kernel/src dm-cmirror-client.c ... Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2006-q3/txt/msg00225.txt.bz2 List-Id: CVSROOT: /cvs/cluster Module name: cluster Branch: RHEL4 Changes by: jbrassow@sourceware.org 2006-07-27 23:11:55 Modified files: cmirror-kernel/src: dm-cmirror-client.c dm-cmirror-common.h dm-cmirror-server.c Log message: - further tightening for 199826 We now refuse to read/write the disk log if we are suspended. We also add BUG_ON() to operations that do I/O to the log device. The reason for the BUG_ON() is that it is better to drop the machine than to have it hang the cluster while it attempts to read/write from a suspended device. That being said, it should now be impossible to get to those functions which would perform I/O operations during suspension. I have still seen cases where the mirror will stall. However, I think this is due to LVM (clvmd), because it happens when a mirror is created while the log device is suspended - which must not happen. I've only seen this when doing simultaneous create/convert/remove from all nodes in the cluster. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-client.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.22&r2=1.1.2.23 http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-common.h.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.9&r2=1.1.2.10 http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-server.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.15&r2=1.1.2.16