From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12657 invoked by alias); 18 Jan 2007 20:40:12 -0000 Received: (qmail 12634 invoked by uid 9572); 18 Jan 2007 20:40:12 -0000 Date: Thu, 18 Jan 2007 20:40:00 -0000 Message-ID: <20070118204012.12633.qmail@sourceware.org> From: wcheng@sourceware.org To: cluster-cvs@sources.redhat.com Subject: cluster/gfs-kernel/src/gfs ops_inode.c Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00156.txt.bz2 CVSROOT: /cvs/cluster Module name: cluster Branch: RHEL4 Changes by: wcheng@sourceware.org 2007-01-18 20:40:12 Modified files: gfs-kernel/src/gfs: ops_inode.c Log message: bugzilla 190475 (rename 3-2): This patch fixes: Current rename doesn't lock the (to be deleted) source file during rename operation unless the source is a directory. This issue would not show up in a single node case since VFS layer has done its i_sem/ i_mutex locks for both directories and involved files. This patch excludes a previous proposed change (in the draft patch sent out for review in cluster-devel list) that adds gfs rename global lock to prevent a rare case of cluster deadlock. Since cluster rename global lock is very expensive, we prefer to find other means to fix that issue. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_inode.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.6.2.4&r2=1.6.2.5