From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10975 invoked by alias); 20 Feb 2007 19:35:11 -0000 Received: (qmail 10958 invoked by uid 9478); 20 Feb 2007 19:35:11 -0000 Date: Tue, 20 Feb 2007 19:35:00 -0000 Message-ID: <20070220193511.10957.qmail@sourceware.org> From: jbrassow@sourceware.org To: cluster-cvs@sources.redhat.com Subject: cluster/cmirror-kernel/src dm-cmirror-client.c ... Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00436.txt.bz2 CVSROOT: /cvs/cluster Module name: cluster Branch: RHEL4 Changes by: jbrassow@sourceware.org 2007-02-20 19:35:10 Modified files: cmirror-kernel/src: dm-cmirror-client.c dm-cmirror-cman.c dm-cmirror-cman.h dm-cmirror-server.c Log message: Bug 217895: lost election results from cmirror server cause mirror ... There was a race happening as a result of simultaneous cman issued 'starts'. The client receives the start requests, but the server processes them. So, it was possible for the server to reset the event id/type while the client was trying to set them. This would cause the next kcl_start_done command issued by the server to fail. The bug can be interpretted many different ways depending on which machine in the cluster you are looking at when it happens. The fix was to have the client wait to set the event id/type until it knows the server has completed the previous request. This fix may resolve other bugs as well, but I will test them individually. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-client.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.37&r2=1.1.2.38 http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-cman.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.5&r2=1.1.2.6 http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-cman.h.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.1&r2=1.1.2.2 http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-server.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.22&r2=1.1.2.23