public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: teigland@sourceware.org To: cluster-cvs@sources.redhat.com Subject: cluster/gfs-kernel/src/dlm mount.c Date: Mon, 14 Jan 2008 15:35:00 -0000 [thread overview] Message-ID: <20080114153530.26335.qmail@sourceware.org> (raw) CVSROOT: /cvs/cluster Module name: cluster Branch: RHEL4 Changes by: teigland@sourceware.org 2008-01-14 15:35:30 Modified files: gfs-kernel/src/dlm: mount.c Log message: bz 324881 It's easy to tell if you've hit this bug, because a message like this will always appear in /var/log/messages: SM: 02000378 ignoring service callback id=2000144 event=1324 If you look at /proc/cluster/lock_dlm/debug on this node at this point, you'll see something like this at the end, which shows what the problem is: others_may_mount start_done 1322 b The event_id that others_may_mount uses when calling kcl_start_done() is incorrect; it's using 1322 when it should be 1324. I believe the fix is for others_may_mount() to read the event_id after taking the umount_lock semaphore which serializes others_may_mount() with a start callback from the lock_dlm thread. In this case, I believe the start callback is changing the event_id after others_may_mount reads it, and before othres_may_mount gets the umount_lock semaphore. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/dlm/mount.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.11.2.3&r2=1.11.2.4
next reply other threads:[~2008-01-14 15:35 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-14 15:35 teigland [this message] -- strict thread matches above, loose matches on Subject: below -- 2005-11-11 23:43 teigland 2005-08-10 7:30 teigland
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080114153530.26335.qmail@sourceware.org \ --to=teigland@sourceware.org \ --cc=cluster-cvs@sources.redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).