From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5623 invoked by alias); 14 Jan 2008 16:00:21 -0000 Received: (qmail 5605 invoked by uid 9453); 14 Jan 2008 16:00:20 -0000 Date: Mon, 14 Jan 2008 16:00:00 -0000 Message-ID: <20080114160020.5604.qmail@sourceware.org> From: teigland@sourceware.org To: cluster-cvs@sources.redhat.com Subject: cluster/gfs-kernel/src/dlm thread.c Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00060.txt.bz2 CVSROOT: /cvs/cluster Module name: cluster Branch: RHEL4 Changes by: teigland@sourceware.org 2008-01-14 16:00:20 Modified files: gfs-kernel/src/dlm: thread.c Log message: bz 352731 I've looked at other users of kthread_stop()/kthread_should_stop(), and most seem to incorporate a call to kthread_should_stop() within the test that adds the thread to a wait_queue. I'm guessing that that's what we should be doing also (and at the same time using wait_event_interruptible() instead of an open-coded equivalent.) Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/dlm/thread.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.16.2.6&r2=1.16.2.7