From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23972 invoked by alias); 24 Jan 2008 20:25:11 -0000 Received: (qmail 23949 invoked by uid 9475); 24 Jan 2008 20:25:10 -0000 Date: Thu, 24 Jan 2008 20:25:00 -0000 Message-ID: <20080124202510.23947.qmail@sourceware.org> From: bmarzins@sourceware.org To: cluster-cvs@sources.redhat.com Subject: cluster/gfs-kernel/src/gfs glock.c Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00125.txt.bz2 CVSROOT: /cvs/cluster Module name: cluster Branch: RHEL5 Changes by: bmarzins@sourceware.org 2008-01-24 20:25:10 Modified files: gfs-kernel/src/gfs: glock.c Log message: Fix for bz #426291. gfs_glock_dq was traversing the gl_holders list without holding the gl_spin spinlock, this was causing a problem when the list item it was currently looking at got removed from the list. The solution is to not traverse the list, because it is unncessary. Unfortunately, there is also a bug in this section of code, where you can't guarantee that you will not cache a glock held with GL_NOCACHE. Fixing this issue requires significantly more work. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.29.2.5&r2=1.29.2.6