public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: teigland@sourceware.org To: cluster-cvs@sources.redhat.com, cluster-devel@redhat.com Subject: Cluster Project branch, RHEL5, updated. cmirror_1_1_15-48-gafb6cf2 Date: Wed, 16 Apr 2008 14:28:00 -0000 [thread overview] Message-ID: <20080416142822.13270.qmail@sourceware.org> (raw) This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Cluster Project". http://sources.redhat.com/git/gitweb.cgi?p=cluster.git;a=commitdiff;h=afb6cf25e46a7afc40f97367e26719b29cd0983d The branch, RHEL5 has been updated via afb6cf25e46a7afc40f97367e26719b29cd0983d (commit) from 0847ffdaf607aafd538e949c91eb47f2a06c4335 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit afb6cf25e46a7afc40f97367e26719b29cd0983d Author: David Teigland <teigland@redhat.com> Date: Wed Apr 16 09:22:27 2008 -0500 gfs_controld: retry recovery for withdrawn journal bz 442451 This is unfortunate, but seems to be the best solution available. The problem, described more fully in the bz, is that when gfs_controld tries to do recovery on a journal for a withdraw, the withdrawing node may not yet have cleared its dlm locks. This means the journal lock may still be held by the withdrawing node, causing all the recovering node(s) to fail acquiring it, and no one does the recovery. The solution is for all recovering nodes to retry recovery of a withdrawn journal until they succeed (only the first to get the journal lock will actually recover it, the others will see it's recovered and report success.) Signed-off-by: David Teigland <teigland@redhat.com> ----------------------------------------------------------------------- Summary of changes: group/gfs_controld/recover.c | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/group/gfs_controld/recover.c b/group/gfs_controld/recover.c index 9ce3aa7..52d96ff 100644 --- a/group/gfs_controld/recover.c +++ b/group/gfs_controld/recover.c @@ -1913,6 +1913,25 @@ int kernel_recovery_done(char *table) switch (atoi(buf)) { case LM_RD_GAVEUP: + /* + * This is unfortunate; it's needed for bz 442451 where + * gfs-kernel fails to acquire the journal lock on all nodes + * because a withdrawing node has not yet called + * dlm_release_lockspace() to free it's journal lock. With + * this, all nodes should repeatedly try to to recover the + * journal of the withdrawn node until the withdrawing node + * clears its dlm locks, and gfs on each of the remaining nodes + * succeeds in doing the recovery. + */ + + if (memb->withdrawing) { + log_group(mg, "recovery_done jid %d nodeid %d retry " + "for withdraw", memb->jid, memb->nodeid); + memb->tell_gfs_to_recover = 1; + memb->wait_gfs_recover_done = 0; + usleep(500000); + } + memb->local_recovery_status = RS_GAVEUP; ss = "gaveup"; break; hooks/post-receive -- Cluster Project
reply other threads:[~2008-04-16 14:28 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080416142822.13270.qmail@sourceware.org \ --to=teigland@sourceware.org \ --cc=cluster-cvs@sources.redhat.com \ --cc=cluster-devel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).