From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13416 invoked by alias); 9 May 2008 17:21:00 -0000 Received: (qmail 13383 invoked by uid 9585); 9 May 2008 17:21:00 -0000 Date: Fri, 09 May 2008 17:21:00 -0000 Message-ID: <20080509172059.13368.qmail@sourceware.org> From: adas@sourceware.org To: cluster-cvs@sources.redhat.com, cluster-devel@redhat.com Subject: Cluster Project branch, RHEL4, updated. gfs-kernel_2_6_9_76-54-g4a882ef X-Git-Refname: refs/heads/RHEL4 X-Git-Reftype: branch X-Git-Oldrev: b5ab5afac7d6cd8c696b46bacb022ae528d636fe X-Git-Newrev: 4a882ef9601cece3e5383dc22965902ed462f7e2 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2008-q2/txt/msg00280.txt.bz2 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Cluster Project". http://sources.redhat.com/git/gitweb.cgi?p=cluster.git;a=commitdiff;h=4a882ef9601cece3e5383dc22965902ed462f7e2 The branch, RHEL4 has been updated via 4a882ef9601cece3e5383dc22965902ed462f7e2 (commit) from b5ab5afac7d6cd8c696b46bacb022ae528d636fe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4a882ef9601cece3e5383dc22965902ed462f7e2 Author: Abhijith Das Date: Fri May 9 12:00:05 2008 -0500 gfs-kernel: Workaround fix for bz 444912 (gfs_glock_is_locked_by_me problem) This one-line fix, removes the assert warning. The behavior of the code is unchanged except that the assert warnings will no longer appear in the logs. This warning is tripped through the madvise syscall where control reaches the readpage function without the inode glock being held. We return -ENOSYS in such a case, disabling the madvise syscall. A more elegant fix for RHEL5 gfs that supports the madvise syscall (bz 429343) could not be ported to RHEL4 because AOP_TRUNCATED_PAGE is not available in RHEL4. ----------------------------------------------------------------------- Summary of changes: gfs-kernel/src/gfs/ops_address.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gfs-kernel/src/gfs/ops_address.c b/gfs-kernel/src/gfs/ops_address.c index af5b3b3..fb17133 100644 --- a/gfs-kernel/src/gfs/ops_address.c +++ b/gfs-kernel/src/gfs/ops_address.c @@ -283,7 +283,7 @@ gfs_readpage(struct file *file, struct page *page) atomic_inc(&sdp->sd_ops_address); - if (gfs_assert_warn(sdp, gfs_glock_is_locked_by_me(ip->i_gl))) { + if (!gfs_glock_is_locked_by_me(ip->i_gl)) { unlock_page(page); return -ENOSYS; } hooks/post-receive -- Cluster Project