public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: David Teigland <teigland@fedoraproject.org> To: cluster-cvs-relay@redhat.com Subject: master - gfs_controld: fix fs_notify during recovery Date: Fri, 15 Aug 2008 06:02:00 -0000 [thread overview] Message-ID: <20080814210409.782C212002B@lists.fedorahosted.org> (raw) Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=60132fc9c185be95a6cc480bd535412995a167a2 Commit: 60132fc9c185be95a6cc480bd535412995a167a2 Parent: 44861eae0e3530360c6e848aa5d86f482ede70e5 Author: David Teigland <teigland@redhat.com> AuthorDate: Thu Aug 14 15:53:21 2008 -0500 Committer: David Teigland <teigland@redhat.com> CommitterDate: Thu Aug 14 15:53:21 2008 -0500 gfs_controld: fix fs_notify during recovery Wasn't processing mountgroup again after an initial failed fs_notify, so no retry was happening. Also, the process_mountgroup check was wrongly skipping the apply_changes phase sometimes at the very start because there was no change struct yet, which would cause a segfault. Signed-off-by: David Teigland <teigland@redhat.com> --- group/gfs_controld/cpg-new.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/group/gfs_controld/cpg-new.c b/group/gfs_controld/cpg-new.c index d72d907..28445c1 100644 --- a/group/gfs_controld/cpg-new.c +++ b/group/gfs_controld/cpg-new.c @@ -622,6 +622,8 @@ void process_dlmcontrol(int ci) } poll_dlm = 0; + + process_mountgroup(mg); } static int check_dlm_notify_done(struct mountgroup *mg) @@ -657,8 +659,8 @@ static int check_dlm_notify_done(struct mountgroup *mg) dlmc_fs_notified() again in a bit */ if (node->dlm_notify_callback && node->dlm_notify_result) { - log_group(mg, "check_dlm_notify will retry nodeid %d", - node->nodeid); + log_group(mg, "check_dlm_notify result %d will retry nodeid %d", + node->dlm_notify_result, node->nodeid); node->dlm_notify_callback = 0; poll_dlm = 1; return 0; @@ -2065,7 +2067,7 @@ static void process_mountgroup(struct mountgroup *mg) if (!list_empty(&mg->changes)) apply_changes(mg); - if (list_empty(&mg->changes)) + if (mg->started_change && list_empty(&mg->changes)) recover_and_start(mg); }
reply other threads:[~2008-08-14 21:05 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080814210409.782C212002B@lists.fedorahosted.org \ --to=teigland@fedoraproject.org \ --cc=cluster-cvs-relay@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).