public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: "Ryan O'Hara" <rohara@fedoraproject.org> To: cluster-cvs-relay@redhat.com Subject: RHEL4 - fence_scsi.pl: check if nodeid is zero Date: Fri, 05 Sep 2008 13:06:00 -0000 [thread overview] Message-ID: <20080904213542.9DC4D1203BA@lists.fedorahosted.org> (raw) Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=3df1a7c5dd25d0579b6d82fb8375efb9f4ecf0eb Commit: 3df1a7c5dd25d0579b6d82fb8375efb9f4ecf0eb Parent: 3ac098920b654410883a31e762fdd150b6f21c14 Author: rohara <rohara@spartan.(none)> AuthorDate: Thu Sep 4 16:35:42 2008 -0500 Committer: rohara <rohara@spartan.(none)> CommitterDate: Thu Sep 4 16:35:42 2008 -0500 fence_scsi.pl: check if nodeid is zero If the nodeid we get from the XML query of cluster.conf is zero, then either the node does not exist in the cluster of the nodeid is not set. Each case is invalid, so report an error and exit. --- fence/agents/scsi/fence_scsi.pl | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fence/agents/scsi/fence_scsi.pl b/fence/agents/scsi/fence_scsi.pl index c2dea6f..e0da751 100755 --- a/fence/agents/scsi/fence_scsi.pl +++ b/fence/agents/scsi/fence_scsi.pl @@ -187,6 +187,10 @@ sub get_key my $cluster_id = get_cluster_id; my $node_id = get_node_id($node); + if ($node_id == 0) { + die "Unable to determine nodeid for $node.\n"; + } + my $key = sprintf "%x%.4x", $cluster_id, $node_id; return $key;
reply other threads:[~2008-09-04 21:36 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080904213542.9DC4D1203BA@lists.fedorahosted.org \ --to=rohara@fedoraproject.org \ --cc=cluster-cvs-relay@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).