public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: "Fabio M. Di Nitto" <fabbione@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: STABLE2 - [FENCE] Fix #290231 - "Switch (optional)" param does not default to "1" and program fails
Date: Fri, 26 Sep 2008 14:50:00 -0000	[thread overview]
Message-ID: <20080926083841.1A88E120444@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=897627c5e22ba9f78a22cd213d02acb1fa7b68f4
Commit:        897627c5e22ba9f78a22cd213d02acb1fa7b68f4
Parent:        fedd56b97fdc9b9bb2fa47958d14b9a324c4df3b
Author:        Marek 'marx' Grac <mgrac@redhat.com>
AuthorDate:    Wed Sep 24 16:46:35 2008 +0200
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Fri Sep 26 10:38:18 2008 +0200

[FENCE] Fix #290231 - "Switch (optional)" param does not default to "1" and program fails

    Bug itself was almost corrected in new fence agent but unfortunately '1' was
    entered as number not as string. Python can not do int + string and agent fails.
---
 fence/agents/apc/fence_apc.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fence/agents/apc/fence_apc.py b/fence/agents/apc/fence_apc.py
index b8f0637..5d132be 100644
--- a/fence/agents/apc/fence_apc.py
+++ b/fence/agents/apc/fence_apc.py
@@ -41,7 +41,7 @@ def get_power_status(conn, options):
 					fail_usage("Failed: You have to enter physical switch number")
 			else:
 				if (0 == options.has_key("-s")):
-					options["-s"] = 1
+					options["-s"] = "1"
 
 		if (None == re.compile('.*Outlet Management.*', re.IGNORECASE | re.S).match(conn.before)):
 			version = 2


                 reply	other threads:[~2008-09-26  8:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080926083841.1A88E120444@lists.fedorahosted.org \
    --to=fabbione@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).