public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
* STABLE2 - rgmanager: randomize ASEHAagent temp files even more
@ 2008-10-30  9:20 Fabio M. Di Nitto
  0 siblings, 0 replies; only message in thread
From: Fabio M. Di Nitto @ 2008-10-30  9:20 UTC (permalink / raw)
  To: cluster-cvs-relay

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=cf6518b7cd0547b24493c088cbd8d442c5d0c180
Commit:        cf6518b7cd0547b24493c088cbd8d442c5d0c180
Parent:        f186ae843357846ae742f578f7965ea94b67a410
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Thu Oct 30 10:18:19 2008 +0100
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Thu Oct 30 10:19:54 2008 +0100

rgmanager: randomize ASEHAagent temp files even more

f8943d17d4c108d44af7a42ad0fd646d4e75990e didn't didn't introduce enough
security.

Switch to mktemp(1).

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 rgmanager/src/resources/ASEHAagent.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/rgmanager/src/resources/ASEHAagent.sh b/rgmanager/src/resources/ASEHAagent.sh
index 35f3fa1..ddf52c9 100644
--- a/rgmanager/src/resources/ASEHAagent.sh
+++ b/rgmanager/src/resources/ASEHAagent.sh
@@ -781,8 +781,8 @@ deep_probe()
 	ocf_log debug "ASEHAagent: Start 'deep_probe'."	
 
 	# Declare two temporary files which will be used in this probe.
-	tmpfile1="/tmp/ASEHAagent.1.$$"
-	tmpfile2="/tmp/ASEHAagent.2.$$"
+	tmpfile1="$(mktemp -t /tmp/ASEHAagent.1.XXXXXX)"
+	tmpfile2="$(mktemp -t /tmp/ASEHAagent.2.XXXXXX)"
 	
 	# Get the login_string by analyzing the login_file.
 	get_login_string


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-10-30  9:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-30  9:20 STABLE2 - rgmanager: randomize ASEHAagent temp files even more Fabio M. Di Nitto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).