public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jan Friesse <honzaf@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: cluster: STABLE2 - fence: fix IPMI spawn /bin/bash rather than /bin/sh
Date: Thu, 20 Nov 2008 13:44:00 -0000	[thread overview]
Message-ID: <20081120134336.26D4AC046B@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=d57fba422b8c5822bc751cc190277367e42ad597
Commit:        d57fba422b8c5822bc751cc190277367e42ad597
Parent:        47514a9ac69f4b6ef0bcd87a2763de24dff12f5d
Author:        Jan Friesse <jfriesse@redhat.com>
AuthorDate:    Thu Nov 20 14:39:20 2008 +0100
Committer:     Jan Friesse <jfriesse@redhat.com>
CommitterDate: Thu Nov 20 14:42:52 2008 +0100

fence: fix IPMI spawn /bin/bash rather than /bin/sh

It's not guaranteed, that /bin/sh will be symlink to
shell, which is bash (or ksh) compliant, so it's better
to use /bin/bash.
---
 fence/agents/ipmilan/expect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fence/agents/ipmilan/expect.c b/fence/agents/ipmilan/expect.c
index 4156886..fa85bd8 100644
--- a/fence/agents/ipmilan/expect.c
+++ b/fence/agents/ipmilan/expect.c
@@ -304,7 +304,7 @@ StartProcess(const char * cmd, int * readfd, int * writefd, int flags)
 			sched_setscheduler(0, SCHED_OTHER, &sp);
 		}
 #endif
-		execlp("/bin/sh", "sh", "-c", cmd, NULL);
+		execlp("/bin/bash", "bash", "-c", cmd, NULL);
 		perror("cannot exec shell!");
 		exit(1);
 


                 reply	other threads:[~2008-11-20 13:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081120134336.26D4AC046B@lists.fedorahosted.org \
    --to=honzaf@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).