public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@fedoraproject.org> To: cluster-cvs-relay@redhat.com Subject: cluster: RHEL53 - Non-default block size confuses gfs2_grow Date: Mon, 02 Feb 2009 15:18:00 -0000 [thread overview] Message-ID: <20090202151749.6051B120597@lists.fedorahosted.org> (raw) Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=6d221b0e4603b3f41fef4660846d06664e88dca5 Commit: 6d221b0e4603b3f41fef4660846d06664e88dca5 Parent: 443747661081fc81d872e609585e831350fb0802 Author: Bob Peterson <rpeterso@redhat.com> AuthorDate: Wed Jan 21 10:14:02 2009 -0600 Committer: Bob Peterson <rpeterso@redhat.com> CommitterDate: Mon Feb 2 08:44:58 2009 -0600 Non-default block size confuses gfs2_grow bz 469773 (originally) When gfs2_grow calculates the number of new resource groups needed for an extended file system, it was doing so using values calculated before the superblock was read in. Therefore it used the default block size (4K) regardless of the actual block size. This patch moves the call to fix_device_geometry after the superblock has been read in so the calculations are done using the correct block size. --- gfs2/mkfs/main_grow.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gfs2/mkfs/main_grow.c b/gfs2/mkfs/main_grow.c index 2ac6e78..39989e6 100644 --- a/gfs2/mkfs/main_grow.c +++ b/gfs2/mkfs/main_grow.c @@ -282,7 +282,6 @@ main_grow(int argc, char *argv[]) die("can't open device %s: %s\n", sdp->device_name, strerror(errno)); device_geometry(sdp); - fix_device_geometry(sdp); log_info("Initializing lists...\n"); osi_list_init(&sdp->rglist); init_buf_list(sdp, &sdp->buf_list, 128 << 20); @@ -294,6 +293,7 @@ main_grow(int argc, char *argv[]) if(read_sb(sdp) < 0) die("gfs: Error reading superblock.\n"); + fix_device_geometry(sdp); if (!find_gfs2_meta(sdp)) mount_gfs2_meta(sdp); lock_for_admin(sdp);
reply other threads:[~2009-02-02 15:18 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090202151749.6051B120597@lists.fedorahosted.org \ --to=rpeterso@fedoraproject.org \ --cc=cluster-cvs-relay@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).