public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: Christine Caulfield <chrissie@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: cluster: master - cman: Fix name resolving.
Date: Wed, 04 Feb 2009 10:26:00 -0000	[thread overview]
Message-ID: <20090204102604.4EB1C1205B2@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=6f5b61f3e93595788cffe162994212572d348ca5
Commit:        6f5b61f3e93595788cffe162994212572d348ca5
Parent:        1004eb573e03ec684b2a73199cf7d94cb8cce8f6
Author:        Christine Caulfield <ccaulfie@redhat.com>
AuthorDate:    Wed Feb 4 10:25:40 2009 +0000
Committer:     Christine Caulfield <ccaulfie@redhat.com>
CommitterDate: Wed Feb 4 10:25:40 2009 +0000

cman: Fix name resolving.

corosync success is CS_OK, not 0!

Signed-off-by: Christine Caulfield <ccaulfie@redhat.com>
---
 cman/services/cman/lib/libcman.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/cman/services/cman/lib/libcman.c b/cman/services/cman/lib/libcman.c
index 7a25a9d..09ca151 100644
--- a/cman/services/cman/lib/libcman.c
+++ b/cman/services/cman/lib/libcman.c
@@ -1087,10 +1087,12 @@ int cman_get_nodes(cman_handle_t handle, int maxnodes, int *retnodes, cman_node_
 		for (i=0; i < cman_inst->node_count; i++) {
 			nodes[i].cn_nodeid = cman_inst->node_list[i].nodeid;
 			nodes[i].cn_member = 1;
+			name = NULL;
 
 			error = corosync_cfg_get_node_addrs(cman_inst->cfg_handle, nodes[i].cn_nodeid, max_addrs, &num_addrs, addrs);
-			if (!error)
+			if (error == CS_OK) {
 				name = node_name(&addrs[0]);
+			}
 			if (name) {
 				sprintf(nodes[i].cn_name, "%s", name);
 			}


                 reply	other threads:[~2009-02-04 10:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090204102604.4EB1C1205B2@lists.fedorahosted.org \
    --to=chrissie@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).