public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: "Fabio M. Di Nitto" <fabbione@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: resource-agents: master - build: stricter install invokation
Date: Wed, 25 Feb 2009 10:20:00 -0000	[thread overview]
Message-ID: <20090225101958.238B112020C@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/resource-agents.git?p=resource-agents.git;a=commitdiff;h=ae33db76636140289967c56ccf5835b386ff7bc0
Commit:        ae33db76636140289967c56ccf5835b386ff7bc0
Parent:        9c68101faee7da5dbcb2638880924f8ca23bc750
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Fri Feb 20 06:53:24 2009 +0100
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Wed Feb 25 11:19:48 2009 +0100

build: stricter install invokation

make install fails in shell loops to detect errors.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 make/install.mk                  |    1 +
 rgmanager/src/resources/Makefile |    4 ++++
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/make/install.mk b/make/install.mk
index 26e4d2e..b73ccdf 100644
--- a/make/install.mk
+++ b/make/install.mk
@@ -1,6 +1,7 @@
 install:
 ifdef DOCS
 	install -d ${docdir}
+	set -e; \
 	for i in ${DOCS}; do \
 		install -m644 $(S)/$$i ${docdir}; \
 	done
diff --git a/rgmanager/src/resources/Makefile b/rgmanager/src/resources/Makefile
index 3c8c1f9..a764ef7 100644
--- a/rgmanager/src/resources/Makefile
+++ b/rgmanager/src/resources/Makefile
@@ -48,15 +48,19 @@ $(TARGET3):
 
 install:
 	install -d ${sharedir}/utils
+	set -e; \
 	for i in $(RESOURCES); do \
 	 install -m755 $(S)/$$i ${sharedir}; \
 	done
+	set -e; \
 	for i in $(METADATA) $(EVENT_TARGETS); do \
 	 install -m644 $(S)/$$i ${sharedir}; \
 	done
+	set -e; \
 	for i in $(GENERAL_TARGETS); do \
 	 install -m755 $(S)/$$i ${sharedir}; \
 	done
+	set -e; \
 	for i in $(UTIL_TARGETS); do \
 	 install -m755 $(S)/$$i ${sharedir}/utils; \
 	done


                 reply	other threads:[~2009-02-25 10:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090225101958.238B112020C@lists.fedorahosted.org \
    --to=fabbione@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).