public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: Lon Hohberger <lon@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: cluster: RHEL4 - rgmanager: fix ambiguous output when resource fails to stop
Date: Thu, 12 Mar 2009 21:40:00 -0000	[thread overview]
Message-ID: <20090312214014.C848F1201BF@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=1e89c485ec2de1f91727569ba3230b36b26034d3
Commit:        1e89c485ec2de1f91727569ba3230b36b26034d3
Parent:        46a8552a07c7e72122c9495c74eb97276a31b7bc
Author:        Lon Hohberger <lhh@redhat.com>
AuthorDate:    Mon Mar 2 15:36:00 2009 -0500
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Thu Mar 12 17:40:09 2009 -0400

rgmanager: fix ambiguous output when resource fails to stop

https://bugzilla.redhat.com/show_bug.cgi?id=480835

Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
 rgmanager/src/daemons/rg_state.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/rgmanager/src/daemons/rg_state.c b/rgmanager/src/daemons/rg_state.c
index df0ac1b..c717ecc 100644
--- a/rgmanager/src/daemons/rg_state.c
+++ b/rgmanager/src/daemons/rg_state.c
@@ -974,7 +974,10 @@ _svc_stop(char *svcName, int req, int recover, uint32_t newstate)
 	}
 	rg_unlock(svcName, lockp);
 
-	ret = group_op(svcName, RG_STOP);
+	if (group_op(svcName, RG_STOP) != 0)
+		ret = RG_EFAIL;
+	else
+		ret = 0;
 
 	if (old_state == RG_STATE_FAILED && newstate == RG_STATE_DISABLED) {
 		if (ret)


                 reply	other threads:[~2009-03-12 21:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090312214014.C848F1201BF@lists.fedorahosted.org \
    --to=lon@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).