public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: David Teigland <teigland@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: fence: master - fenced: fix lockfile
Date: Mon, 16 Mar 2009 22:02:00 -0000	[thread overview]
Message-ID: <20090316220224.5EA6F1201FC@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/fence.git?p=fence.git;a=commitdiff;h=d3b33ac0f2afa8c44dc3c7fd5dee6a4f769eb409
Commit:        d3b33ac0f2afa8c44dc3c7fd5dee6a4f769eb409
Parent:        0d0d4115d32e71f6c418ab040e86d2d377d792e7
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Mon Mar 16 16:58:14 2009 -0500
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Mon Mar 16 16:58:14 2009 -0500

fenced: fix lockfile

fenced was taking a lock on its lockfile before forking, but
forking clears the locks, so it needs to happen after the fork.

Signed-off-by: David Teigland <teigland@redhat.com>
---
 fence/fenced/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fence/fenced/main.c b/fence/fenced/main.c
index ddba022..9096c7c 100644
--- a/fence/fenced/main.c
+++ b/fence/fenced/main.c
@@ -971,7 +971,6 @@ int main(int argc, char **argv)
 	INIT_LIST_HEAD(&controlled_entries);
 
 	read_arguments(argc, argv);
-	lockfile();
 
 	if (!daemon_debug_opt) {
 		if (daemon(0, 0) < 0) {
@@ -980,6 +979,7 @@ int main(int argc, char **argv)
 		}
 		umask(0);
 	}
+	lockfile();
 	init_logging();
 	log_level(LOG_INFO, "fenced %s", RELEASE_VERSION);
 	signal(SIGTERM, sigterm_handler);


                 reply	other threads:[~2009-03-16 22:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090316220224.5EA6F1201FC@lists.fedorahosted.org \
    --to=teigland@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).