public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: David Teigland <teigland@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: dlm: master - dlm_tool: ls failure should exit with failure
Date: Fri, 27 Mar 2009 17:57:00 -0000	[thread overview]
Message-ID: <20090327175702.373EE12020C@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/dlm.git?p=dlm.git;a=commitdiff;h=9ece1eee48182537cf54f20ee54bece54cfd64dc
Commit:        9ece1eee48182537cf54f20ee54bece54cfd64dc
Parent:        d412e873107000491b0a2c77bb4f6b52b523772c
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Fri Mar 27 11:35:26 2009 -0500
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Fri Mar 27 12:52:52 2009 -0500

dlm_tool: ls failure should exit with failure

exit code of list command can be used to check if dlm_controld is running

Signed-off-by: David Teigland <teigland@redhat.com>
---
 dlm/tool/main.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/dlm/tool/main.c b/dlm/tool/main.c
index c247044..631fb56 100644
--- a/dlm/tool/main.c
+++ b/dlm/tool/main.c
@@ -1182,16 +1182,15 @@ static void do_list(char *name)
 	memset(lss, 0, sizeof(lss));
 
 	if (name) {
-		rv = dlmc_lockspace_info(name, lss);
-		if (rv < 0)
-			return;
 		ls_count = 1;
+		rv = dlmc_lockspace_info(name, lss);
 	} else {
 		rv = dlmc_lockspaces(MAX_LS, &ls_count, lss);
-		if (rv < 0)
-			return;
 	}
 
+	if (rv < 0)
+		exit(EXIT_FAILURE); /* dlm_controld probably not running */
+
 	if (ls_count)
 		printf("dlm lockspaces\n");
 


                 reply	other threads:[~2009-03-27 17:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090327175702.373EE12020C@lists.fedorahosted.org \
    --to=teigland@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).