public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: "Fabio M. Di Nitto" <fabbione@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: cluster: STABLE3 - cman init: fix return vs exit bug
Date: Fri, 27 Mar 2009 19:20:00 -0000	[thread overview]
Message-ID: <20090327190615.E02E412020C@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=ba5ec133c6cc16d4f6f4bb4113f261715b7390fc
Commit:        ba5ec133c6cc16d4f6f4bb4113f261715b7390fc
Parent:        ddffd05beeb88b79a42adf1beee4f15dff155c54
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Wed Mar 25 11:06:45 2009 +0100
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Fri Mar 27 20:05:45 2009 +0100

cman init: fix return vs exit bug

nok should exit and not return.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 cman/init.d/cman.in |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/cman/init.d/cman.in b/cman/init.d/cman.in
index ebb6b64..bf40226 100644
--- a/cman/init.d/cman.in
+++ b/cman/init.d/cman.in
@@ -146,7 +146,7 @@ ok() {
 nok() {
 	failure
 	echo
-	return 1
+	exit 1
 }
 
 load_modules()
@@ -219,7 +219,6 @@ unfence_self()
 		;;
 		1)
 			nok
-			return 1
 		;;
 		2)
 			echo -n "unconfigured"


                 reply	other threads:[~2009-03-27 19:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090327190615.E02E412020C@lists.fedorahosted.org \
    --to=fabbione@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).