public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: "Fabio M. Di Nitto" <fabbione@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: cluster: STABLE3 - cman init: factor a file into a var
Date: Fri, 27 Mar 2009 19:07:00 -0000	[thread overview]
Message-ID: <20090327190713.6B71E12020C@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=881639f586306925b9245be53f03b5679bf30d0a
Commit:        881639f586306925b9245be53f03b5679bf30d0a
Parent:        579c7059a9348d447a2a07694f9127e2b68b3def
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Thu Mar 26 15:53:14 2009 +0100
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Fri Mar 27 20:05:47 2009 +0100

cman init: factor a file into a var

don't dupe the same filename 3 times

Thanks to Jim M. for spotting it.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 cman/init.d/cman.in |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/cman/init.d/cman.in b/cman/init.d/cman.in
index e1efb18..ca34398 100644
--- a/cman/init.d/cman.in
+++ b/cman/init.d/cman.in
@@ -423,12 +423,14 @@ stop_configfs()
 
 set_networking_params()
 {
-	[ ! -f  /proc/sys/net/core/rmem_default ] && return 0
+	rmemdefault=/proc/sys/net/core/rmem_default
 
-	value="$(cat /proc/sys/net/core/rmem_default)"
+	[ ! -f $rmemdefault ] && return 0
+
+	value="$(cat $rmemdefault)"
 
 	[ $value -le $NET_RMEM_DEFAULT ] && \
-		echo $NET_RMEM_DEFAULT > /proc/sys/net/core/rmem_default
+		echo $NET_RMEM_DEFAULT > $rmemdefault
 
 	value="$(cat /proc/sys/net/core/rmem_max)"
 


                 reply	other threads:[~2009-03-27 19:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090327190713.6B71E12020C@lists.fedorahosted.org \
    --to=fabbione@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).