public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: David Teigland <teigland@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: dlm: master - dlm_controld: add some log messages
Date: Tue, 31 Mar 2009 15:06:00 -0000	[thread overview]
Message-ID: <20090331150608.00ADC120197@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/dlm.git?p=dlm.git;a=commitdiff;h=625fa3e6ded1623146e7bcd06a3372fb4f616f2b
Commit:        625fa3e6ded1623146e7bcd06a3372fb4f616f2b
Parent:        9ece1eee48182537cf54f20ee54bece54cfd64dc
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Tue Mar 31 10:00:26 2009 -0500
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Tue Mar 31 10:00:26 2009 -0500

dlm_controld: add some log messages

providing more info about the shutdown process

Signed-off-by: David Teigland <teigland@redhat.com>
---
 group/dlm_controld/main.c |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/group/dlm_controld/main.c b/group/dlm_controld/main.c
index 9fde4f3..32ed522 100644
--- a/group/dlm_controld/main.c
+++ b/group/dlm_controld/main.c
@@ -839,6 +839,7 @@ void cluster_dead(int ci)
 
 static void loop(void)
 {
+	struct lockspace *ls;
 	int poll_timeout = -1;
 	int rv, i;
 	void (*workfn) (int ci);
@@ -856,9 +857,8 @@ static void loop(void)
 	rv = setup_cluster_cfg();
 	if (rv < 0)
 		goto out;
-	/* Not all cluster types use cfg */
-	if(rv > 0) 
-	    client_add(rv, process_cluster_cfg, cluster_dead);
+	if (rv > 0) 
+		client_add(rv, process_cluster_cfg, cluster_dead);
 
 	rv = setup_cluster();
 	if (rv < 0)
@@ -919,6 +919,7 @@ static void loop(void)
 		if (rv == -1 && errno == EINTR) {
 			if (daemon_quit && list_empty(&lockspaces))
 				goto out;
+			log_error("shutdown ignored, active lockspaces");
 			daemon_quit = 0;
 			continue;
 		}
@@ -965,6 +966,7 @@ static void loop(void)
 		query_unlock();
 	}
  out:
+	log_debug("shutdown");
 	close_plocks();
 	close_cpg();
 	clear_configfs();
@@ -973,8 +975,8 @@ static void loop(void)
 	close_cluster();
 	close_cluster_cfg();
 
-	if (!list_empty(&lockspaces))
-		log_error("lockspaces abandoned");
+	list_for_each_entry(ls, &lockspaces, list)
+		log_error("abandoned lockspace %s", ls->name);
 }
 
 static void lockfile(void)


                 reply	other threads:[~2009-03-31 15:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090331150608.00ADC120197@lists.fedorahosted.org \
    --to=teigland@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).