From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8878 invoked by alias); 8 Apr 2009 20:52:07 -0000 Received: (qmail 8872 invoked by alias); 8 Apr 2009 20:52:07 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Check-By: sourceware.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bastion2.fedora.phx.redhat.com Subject: cluster: RHEL5 - rgmanager: Fix segfault from missing initializers To: cluster-cvs-relay@redhat.com X-Project: Cluster Project X-Git-Module: cluster.git X-Git-Refname: refs/heads/RHEL5 X-Git-Reftype: branch X-Git-Oldrev: edab820147b90a2190f3d7487f28a35040f667a0 X-Git-Newrev: d5dba53a3bc5c20629b449bee5e3b0be4c71b538 From: Lon Hohberger Message-Id: <20090408205139.49ABA120339@lists.fedorahosted.org> Date: Wed, 08 Apr 2009 20:52:00 -0000 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00057.txt.bz2 Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=d5dba53a3bc5c20629b449bee5e3b0be4c71b538 Commit: d5dba53a3bc5c20629b449bee5e3b0be4c71b538 Parent: edab820147b90a2190f3d7487f28a35040f667a0 Author: Lon Hohberger AuthorDate: Wed Apr 8 16:49:04 2009 -0400 Committer: Lon Hohberger CommitterDate: Wed Apr 8 16:50:40 2009 -0400 rgmanager: Fix segfault from missing initializers If the sets are empty or malloc fails, there is a chance that the set lengths will not be zero like they should, causing a segfault. Signed-off-by: Lon Hohberger --- rgmanager/src/daemons/groups.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c index 6d2ce38..94fa303 100644 --- a/rgmanager/src/daemons/groups.c +++ b/rgmanager/src/daemons/groups.c @@ -430,9 +430,9 @@ check_depend_safe(char *rg_name) int check_rdomain_crash(char *svcName) { - int *nodes = NULL, nodecount; - int *fd_nodes = NULL, fd_nodecount, fl; - int *isect = NULL, icount; + int *nodes = NULL, nodecount = 0; + int *fd_nodes = NULL, fd_nodecount = 0, fl = 0; + int *isect = NULL, icount = 0; char fd_name[256]; if (_group_property(svcName, "domain", fd_name, sizeof(fd_name)) != 0)