From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13338 invoked by alias); 8 Apr 2009 21:01:07 -0000 Received: (qmail 13076 invoked by alias); 8 Apr 2009 21:01:06 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Check-By: sourceware.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bastion2.fedora.phx.redhat.com Subject: cluster: RHEL4 - rgmanager: Fix segfault from missing initializers To: cluster-cvs-relay@redhat.com X-Project: Cluster Project X-Git-Module: cluster.git X-Git-Refname: refs/heads/RHEL4 X-Git-Reftype: branch X-Git-Oldrev: 719b4c225faa87ac4e61127612b53ad0fd648a98 X-Git-Newrev: 6cc6d11249bac6ff21839b96cd924655892d68ee From: Lon Hohberger Message-Id: <20090408210040.6A4F7120339@lists.fedorahosted.org> Date: Wed, 08 Apr 2009 21:01:00 -0000 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00059.txt.bz2 Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=6cc6d11249bac6ff21839b96cd924655892d68ee Commit: 6cc6d11249bac6ff21839b96cd924655892d68ee Parent: 719b4c225faa87ac4e61127612b53ad0fd648a98 Author: Lon Hohberger AuthorDate: Wed Apr 8 16:49:04 2009 -0400 Committer: Lon Hohberger CommitterDate: Wed Apr 8 17:00:05 2009 -0400 rgmanager: Fix segfault from missing initializers If the sets are empty or malloc fails, there is a chance that the set lengths will not be zero like they should, causing a segfault. Only happens w/ previous patch for bug #428108 Signed-off-by: Lon Hohberger --- rgmanager/src/daemons/groups.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c index a0816d5..f26c0d4 100644 --- a/rgmanager/src/daemons/groups.c +++ b/rgmanager/src/daemons/groups.c @@ -435,9 +435,9 @@ check_rdomain_crash(char *svcName) set_type_t *nodes = NULL; set_type_t *fd_nodes = NULL; set_type_t *isect = NULL; - int nodecount; - int fd_nodecount, fl; - int icount; + int nodecount = 0; + int fd_nodecount = 0, fl = 0; + int icount = 0; char fd_name[256]; if (group_property(svcName, "domain", fd_name, sizeof(fd_name)) != 0)