From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cluster-cvs-return-10941-listarch-cluster-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 3926 invoked by alias); 11 May 2009 14:01:51 -0000
Received: (qmail 3738 invoked by alias); 11 May 2009 14:01:51 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0
	tests=AWL,BAYES_00,SPF_HELO_PASS
X-Spam-Status: No, hits=-2.1 required=5.0
	tests=AWL,BAYES_00,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
	bastion2.fedora.phx.redhat.com
Subject: fence-agents: master - fence_scsi_test: #499871 - fence_scsi_test.pl
	does not check for sg_persist in the path
To: cluster-cvs-relay@redhat.com
X-Project: Cluster Project
X-Git-Module: fence-agents.git
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 6c91fc0be692802c6c08ff0474a0c26f850e2ea0
X-Git-Newrev: 97127e8a7778576ebde54e8bba22f2d97cdb83be
From: =?utf-8?q?Marek_Gr=C3=A1c?= <marx@fedoraproject.org>
Message-Id: <20090511140124.7883E1201EC@lists.fedorahosted.org>
Date: Mon, 11 May 2009 14:01:00 -0000
X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254
Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <cluster-cvs.sourceware.org>
List-Subscribe: <mailto:cluster-cvs-subscribe@sourceware.org>
List-Post: <mailto:cluster-cvs@sourceware.org>
List-Help: <mailto:cluster-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: cluster-cvs-owner@sourceware.org
X-SW-Source: 2009-q2/txt/msg00246.txt.bz2

Gitweb:        http://git.fedorahosted.org/git/fence-agents.git?p=fence-agents.git;a=commitdiff;h=97127e8a7778576ebde54e8bba22f2d97cdb83be
Commit:        97127e8a7778576ebde54e8bba22f2d97cdb83be
Parent:        6c91fc0be692802c6c08ff0474a0c26f850e2ea0
Author:        Marek 'marx' Grac <mgrac@redhat.com>
AuthorDate:    Mon May 11 15:57:39 2009 +0200
Committer:     Marek 'marx' Grac <mgrac@redhat.com>
CommitterDate: Mon May 11 15:57:39 2009 +0200

fence_scsi_test: #499871 - fence_scsi_test.pl does not check for sg_persist in the path

---
 fence/agents/scsi/fence_scsi_test.pl |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/fence/agents/scsi/fence_scsi_test.pl b/fence/agents/scsi/fence_scsi_test.pl
index 357a824..cba3c21 100644
--- a/fence/agents/scsi/fence_scsi_test.pl
+++ b/fence/agents/scsi/fence_scsi_test.pl
@@ -175,8 +175,23 @@ sub print_usage
     print "  -h     Help. Prints out this usage information.\n\n";
 }
 
+sub test_tools_path
+{
+    my $tool_name = "sg_persist";
+    
+    for my $path ( split /:/, $ENV{PATH} ) {
+        if ( -f "$path/$tool_name" && -x _ ) {
+          return;
+        }
+    }
+    
+    die "No $tool_name command available, please install the sg3_utils package.\n"
+}
+
 ### MAIN #######################################################################
 
+test_tools_path;
+
 if (getopts("cdhst:v") == 0)
 {
     print_usage;