public inbox for
help / color / mirror / Atom feed
From: David Teigland <>
Subject: cluster: STABLE3 - dlm_tool: fix warning
Date: Mon, 11 May 2009 18:20:00 -0000	[thread overview]
Message-ID: <> (raw)

Commit:        faab5b4212b0e4777648723942cda19cbd192a14
Parent:        160d8dea8b9dae39f80cd79f3b716b346d571204
Author:        David Teigland <>
AuthorDate:    Mon May 11 13:12:17 2009 -0500
Committer:     David Teigland <>
CommitterDate: Mon May 11 13:12:55 2009 -0500

dlm_tool: fix warning

in checking fgets return value

Signed-off-by: David Teigland <>
 dlm/tool/main.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/dlm/tool/main.c b/dlm/tool/main.c
index adb136e..bce0a01 100644
--- a/dlm/tool/main.c
+++ b/dlm/tool/main.c
@@ -947,12 +947,8 @@ static void do_lockdump(char *name)
 	/* skip the header on the first line */
-	if(! (rv = fgets(line, LOCK_LINE_MAX, file))) {
-		if (rv) {
-			fprintf(stderr, "can't read %s: %s\n", path, strerror(errno));
-		}
+	if (!fgets(line, LOCK_LINE_MAX, file))
-	}
 	while (fgets(line, LOCK_LINE_MAX, file)) {
 		rv = sscanf(line, "%x %d %x %u %llu %x %x %hhd %hhd %hhd %u %d %d",

                 reply	other threads:[~2009-05-11 18:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).