public inbox for
help / color / mirror / Atom feed
From: "Fabio M. Di Nitto" <>
Subject: cluster: STABLE3 - gfs2: don't swab in place
Date: Thu, 14 May 2009 08:24:00 -0000	[thread overview]
Message-ID: <> (raw)

Commit:        27ea39325fcfd4200ac6a18eea78452e26818566
Parent:        222a7aa8b36727d11b4485828b0c90a7baddc18d
Author:        Fabio M. Di Nitto <>
AuthorDate:    Thu May 14 10:21:45 2009 +0200
Committer:     Fabio M. Di Nitto <>
CommitterDate: Thu May 14 10:21:45 2009 +0200

gfs2: don't swab in place

because of the way libgfs2 buffers work, it's not safe to swab in place.

Signed-off-by: Fabio M. Di Nitto <>
 gfs2/libgfs2/fs_ops.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/gfs2/libgfs2/fs_ops.c b/gfs2/libgfs2/fs_ops.c
index 0799c03..633ca9e 100644
--- a/gfs2/libgfs2/fs_ops.c
+++ b/gfs2/libgfs2/fs_ops.c
@@ -666,6 +666,7 @@ static int dirent_alloc(struct gfs2_inode *dip, struct gfs2_buffer_head *bh,
 	do {
 		uint16_t cur_rec_len;
 		uint16_t cur_name_len;
+		uint16_t new_rec_len;
 		cur_rec_len = be16_to_cpu(dent->de_rec_len);
 		cur_name_len = be16_to_cpu(dent->de_name_len);
@@ -682,8 +683,8 @@ static int dirent_alloc(struct gfs2_inode *dip, struct gfs2_buffer_head *bh,
 				new->de_name_len = cpu_to_be16(name_len);
-				new->de_rec_len = be16_to_cpu(new->de_rec_len);
-				dent->de_rec_len = cpu_to_be16(cur_rec_len - new->de_rec_len);
+				new_rec_len = be16_to_cpu(new->de_rec_len);
+				dent->de_rec_len = cpu_to_be16(cur_rec_len - new_rec_len);
 				*dent_out = new;
 				return 0;

                 reply	other threads:[~2009-05-14  8:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).