public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: "Fabio M. Di Nitto" <fabbione@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: cluster: STABLE3 - gfs: don't swab in place
Date: Thu, 14 May 2009 08:28:00 -0000	[thread overview]
Message-ID: <20090514082750.764CA120366@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=f0918fef3046b9362cfe9349a4c6589d1b96e3d0
Commit:        f0918fef3046b9362cfe9349a4c6589d1b96e3d0
Parent:        27ea39325fcfd4200ac6a18eea78452e26818566
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Thu May 14 10:21:45 2009 +0200
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Thu May 14 10:27:25 2009 +0200

gfs: don't swab in place

because of the way gfs buffers work, it's not safe to swab in place.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 gfs/gfs_fsck/pass1c.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/gfs/gfs_fsck/pass1c.c b/gfs/gfs_fsck/pass1c.c
index afe4a21..f1918cb 100644
--- a/gfs/gfs_fsck/pass1c.c
+++ b/gfs/gfs_fsck/pass1c.c
@@ -15,11 +15,14 @@ static int remove_eattr_entry(struct fsck_sb *sdp, osi_buf_t *leaf_bh,
 	if(!prev){
 		curr->ea_type = GFS_EATYPE_UNUSED;
 	} else {
-		curr->ea_rec_len = gfs32_to_cpu(curr->ea_rec_len);
-		prev->ea_rec_len = gfs32_to_cpu(prev->ea_rec_len);
+		uint32_t curr_rec_len;
+		uint32_t prev_rec_len;
+
+		curr_rec_len = gfs32_to_cpu(curr->ea_rec_len);
+		prev_rec_len = gfs32_to_cpu(prev->ea_rec_len);
 
 		prev->ea_rec_len =
-			cpu_to_gfs32(curr->ea_rec_len + prev->ea_rec_len);
+			cpu_to_gfs32(curr_rec_len + prev_rec_len);
 		if (curr->ea_flags & GFS_EAFLAG_LAST)
 			prev->ea_flags |= GFS_EAFLAG_LAST;
 	}


                 reply	other threads:[~2009-05-14  8:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090514082750.764CA120366@lists.fedorahosted.org \
    --to=fabbione@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).