From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12860 invoked by alias); 20 May 2009 16:52:16 -0000 Received: (qmail 12851 invoked by alias); 20 May 2009 16:52:15 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_66,SPF_HELO_PASS X-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_66,SPF_HELO_PASS X-Spam-Check-By: sourceware.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bastion2.fedora.phx.redhat.com Subject: cluster: STABLE2 - mount failure after gfs2_edit restoremeta of GFS file system To: cluster-cvs-relay@redhat.com X-Project: Cluster Project X-Git-Module: cluster.git X-Git-Refname: refs/heads/STABLE2 X-Git-Reftype: branch X-Git-Oldrev: 32467b220a4bf6aa08eb861d3595b860572cf5f3 X-Git-Newrev: 872529c4aa5e0501908ec68981fbe408fcba550d From: Bob Peterson Message-Id: <20090520165140.400D01201EC@lists.fedorahosted.org> Date: Wed, 20 May 2009 16:52:00 -0000 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00344.txt.bz2 Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=872529c4aa5e0501908ec68981fbe408fcba550d Commit: 872529c4aa5e0501908ec68981fbe408fcba550d Parent: 32467b220a4bf6aa08eb861d3595b860572cf5f3 Author: Bob Peterson AuthorDate: Wed May 20 10:39:10 2009 -0500 Committer: Bob Peterson CommitterDate: Wed May 20 11:06:14 2009 -0500 mount failure after gfs2_edit restoremeta of GFS file system bz 501732 This patch fixes a problem with gfs2_edit savemeta. The problem was that when saving gfs (gfs1) journals, not enough data was being saved, due to a redundant copy of the log header data that gfs copies into the journal at an offset just short of 512 bytes. Therefore, we need to save 512 bytes of gfs log headers or else gfs won't be able to mount it. --- gfs2/edit/savemeta.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/gfs2/edit/savemeta.c b/gfs2/edit/savemeta.c index 779d715..0e2aaff 100644 --- a/gfs2/edit/savemeta.c +++ b/gfs2/edit/savemeta.c @@ -94,7 +94,13 @@ int get_gfs_struct_info(char *buf, int *block_type, int *struct_len) *struct_len = sizeof(struct gfs2_meta_header); break; case GFS2_METATYPE_LH: /* 8 (log header) */ - *struct_len = sizeof(struct gfs2_log_header); + if (gfs1) + *struct_len = 512; /* gfs copies the log header + twice and compares the copy, + so we need to save all 512 + bytes of it. */ + else + *struct_len = sizeof(struct gfs2_log_header); break; case GFS2_METATYPE_LD: /* 9 (log descriptor) */ *struct_len = sbd.bsize;