From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14735 invoked by alias); 20 May 2009 16:53:39 -0000 Received: (qmail 14729 invoked by alias); 20 May 2009 16:53:39 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_66,SPF_HELO_PASS X-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_66,SPF_HELO_PASS X-Spam-Check-By: sourceware.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bastion2.fedora.phx.redhat.com Subject: cluster: STABLE3 - mount failure after gfs2_edit restoremeta of GFS file system To: cluster-cvs-relay@redhat.com X-Project: Cluster Project X-Git-Module: cluster.git X-Git-Refname: refs/heads/STABLE3 X-Git-Reftype: branch X-Git-Oldrev: 62b8e821509c36b6b35777a0f3c1a459ac084766 X-Git-Newrev: 5092894db39cb3e323648185bcb496f04c9e1938 From: Bob Peterson Message-Id: <20090520165314.174DD1201EC@lists.fedorahosted.org> Date: Wed, 20 May 2009 16:53:00 -0000 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00345.txt.bz2 Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=5092894db39cb3e323648185bcb496f04c9e1938 Commit: 5092894db39cb3e323648185bcb496f04c9e1938 Parent: 62b8e821509c36b6b35777a0f3c1a459ac084766 Author: Bob Peterson AuthorDate: Wed May 20 11:08:19 2009 -0500 Committer: Bob Peterson CommitterDate: Wed May 20 11:08:19 2009 -0500 mount failure after gfs2_edit restoremeta of GFS file system bz 501732 This patch fixes a problem with gfs2_edit savemeta. The problem was that when saving gfs (gfs1) journals, not enough data was being saved, due to a redundant copy of the log header data that gfs copies into the journal at an offset just short of 512 bytes. Therefore, we need to save 512 bytes of gfs log headers or else gfs won't be able to mount it. --- gfs2/edit/savemeta.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/gfs2/edit/savemeta.c b/gfs2/edit/savemeta.c index 4a36652..5b72547 100644 --- a/gfs2/edit/savemeta.c +++ b/gfs2/edit/savemeta.c @@ -92,7 +92,13 @@ static int get_gfs_struct_info(char *gbuf, int *block_type, int *gstruct_len) *gstruct_len = sizeof(struct gfs2_meta_header); break; case GFS2_METATYPE_LH: /* 8 (log header) */ - *gstruct_len = sizeof(struct gfs2_log_header); + if (gfs1) + *gstruct_len = 512; /* gfs copies the log header + twice and compares the copy, + so we need to save all 512 + bytes of it. */ + else + *gstruct_len = sizeof(struct gfs2_log_header); break; case GFS2_METATYPE_LD: /* 9 (log descriptor) */ *gstruct_len = sbd.bsize;