cluster: RHEL5 - rgmanager: randomize smb.sh temp file

[Lon Hohberger <lon@fedoraproject.org>]

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=2e52f12faf68f6d6f56f9e41b9d4c4cfe040b080
Commit:        2e52f12faf68f6d6f56f9e41b9d4c4cfe040b080
Parent:        0b686fd6e06cfb8305ffd6177836536d8868a108
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Thu Oct 30 12:32:08 2008 +0100
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Thu May 21 10:27:58 2009 -0400

rgmanager: randomize smb.sh temp file

by using a static path to /tmp, the operation can be used to trigger
a local DoS by a normal user.

Randomize temp files via mktemp.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 rgmanager/src/resources/smb.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rgmanager/src/resources/smb.sh b/rgmanager/src/resources/smb.sh
index f419f43..71ff4fd 100755
--- a/rgmanager/src/resources/smb.sh
+++ b/rgmanager/src/resources/smb.sh
@@ -350,7 +350,7 @@ add_sha1()
 
 verify_sha1()
 {
-	declare tmpfile="/tmp/smb-$OCF_RESKEY_name.tmp.$$"
+	declare tmpfile="$(mktemp /tmp/smb-${OCF_RESKEY}_name.tmp.XXXXXX)"
 	declare current exp
 
 	exp=$(grep "^# rgmanager-sha1.*$1" "$1" | head -1)