public inbox for
help / color / mirror / Atom feed
From: Lon Hohberger <>
Subject: cluster: RHEL5 - rgmanager: randomize temp file
Date: Thu, 21 May 2009 14:29:00 -0000	[thread overview]
Message-ID: <> (raw)

Commit:        2e52f12faf68f6d6f56f9e41b9d4c4cfe040b080
Parent:        0b686fd6e06cfb8305ffd6177836536d8868a108
Author:        Fabio M. Di Nitto <>
AuthorDate:    Thu Oct 30 12:32:08 2008 +0100
Committer:     Lon Hohberger <>
CommitterDate: Thu May 21 10:27:58 2009 -0400

rgmanager: randomize temp file

by using a static path to /tmp, the operation can be used to trigger
a local DoS by a normal user.

Randomize temp files via mktemp.

Signed-off-by: Fabio M. Di Nitto <>
 rgmanager/src/resources/ |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rgmanager/src/resources/ b/rgmanager/src/resources/
index f419f43..71ff4fd 100755
--- a/rgmanager/src/resources/
+++ b/rgmanager/src/resources/
@@ -350,7 +350,7 @@ add_sha1()
-	declare tmpfile="/tmp/smb-$OCF_RESKEY_name.tmp.$$"
+	declare tmpfile="$(mktemp /tmp/smb-${OCF_RESKEY}_name.tmp.XXXXXX)"
 	declare current exp
 	exp=$(grep "^# rgmanager-sha1.*$1" "$1" | head -1)

                 reply	other threads:[~2009-05-21 14:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).