From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27798 invoked by alias); 21 May 2009 14:29:25 -0000 Received: (qmail 27792 invoked by alias); 21 May 2009 14:29:25 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Check-By: sourceware.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bastion2.fedora.phx.redhat.com Subject: cluster: RHEL5 - rgmanager: randomize ASEHAagent temp files even more To: cluster-cvs-relay@redhat.com X-Project: Cluster Project X-Git-Module: cluster.git X-Git-Refname: refs/heads/RHEL5 X-Git-Reftype: branch X-Git-Oldrev: f47209ebbb923051c4f947f7e933f9e7bf48ff56 X-Git-Newrev: eb922807d65d728ff2896470e8133d9308ba1ae4 From: Lon Hohberger Message-Id: <20090521142835.8328D1201FA@lists.fedorahosted.org> Date: Thu, 21 May 2009 14:29:00 -0000 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00361.txt.bz2 Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=eb922807d65d728ff2896470e8133d9308ba1ae4 Commit: eb922807d65d728ff2896470e8133d9308ba1ae4 Parent: f47209ebbb923051c4f947f7e933f9e7bf48ff56 Author: Fabio M. Di Nitto AuthorDate: Thu Oct 30 10:18:19 2008 +0100 Committer: Lon Hohberger CommitterDate: Thu May 21 10:27:58 2009 -0400 rgmanager: randomize ASEHAagent temp files even more f8943d17d4c108d44af7a42ad0fd646d4e75990e didn't didn't introduce enough security. Switch to mktemp(1). Signed-off-by: Fabio M. Di Nitto --- rgmanager/src/resources/ASEHAagent.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rgmanager/src/resources/ASEHAagent.sh b/rgmanager/src/resources/ASEHAagent.sh index 35f3fa1..ddf52c9 100755 --- a/rgmanager/src/resources/ASEHAagent.sh +++ b/rgmanager/src/resources/ASEHAagent.sh @@ -781,8 +781,8 @@ deep_probe() ocf_log debug "ASEHAagent: Start 'deep_probe'." # Declare two temporary files which will be used in this probe. - tmpfile1="/tmp/ASEHAagent.1.$$" - tmpfile2="/tmp/ASEHAagent.2.$$" + tmpfile1="$(mktemp -t /tmp/ASEHAagent.1.XXXXXX)" + tmpfile2="$(mktemp -t /tmp/ASEHAagent.2.XXXXXX)" # Get the login_string by analyzing the login_file. get_login_string