public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: Lon Hohberger <lon@fedoraproject.org> To: cluster-cvs-relay@redhat.com Subject: cluster: RHEL5 - rgmanager: randomize svclib_nfslock temp dir Date: Thu, 21 May 2009 14:29:00 -0000 [thread overview] Message-ID: <20090521142839.E31FE120214@lists.fedorahosted.org> (raw) Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=c3ca8bc855e3b01c0ca6e169b0d68eee622983e2 Commit: c3ca8bc855e3b01c0ca6e169b0d68eee622983e2 Parent: a36c34552f1655d542ada70a4f3bad45fb602bb5 Author: Fabio M. Di Nitto <fdinitto@redhat.com> AuthorDate: Thu Oct 30 12:36:05 2008 +0100 Committer: Lon Hohberger <lhh@redhat.com> CommitterDate: Thu May 21 10:27:58 2009 -0400 rgmanager: randomize svclib_nfslock temp dir by using a static path to /tmp, the operation can be used to trigger a local DoS by a normal user. Randomize temp dir via mktemp. Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com> --- rgmanager/src/resources/svclib_nfslock | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/rgmanager/src/resources/svclib_nfslock b/rgmanager/src/resources/svclib_nfslock index 2101e1e..a0250b2 100644 --- a/rgmanager/src/resources/svclib_nfslock +++ b/rgmanager/src/resources/svclib_nfslock @@ -37,7 +37,7 @@ # nfslock_statd_notify() { - declare tmpdir=/tmp/statd-$2.$$ + declare tmpdir=$(mktemp -d /tmp/statd-$2.XXXXXX) declare nl_dir=$1 declare nl_ip=$2 declare command # Work around bugs in rpc.statd @@ -55,7 +55,6 @@ nfslock_statd_notify() fi # Ok, copy the HA directory to something we can use. - rm -rf $tmpdir mkdir -p $tmpdir/sm # Copy in our specified entries
reply other threads:[~2009-05-21 14:29 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090521142839.E31FE120214@lists.fedorahosted.org \ --to=lon@fedoraproject.org \ --cc=cluster-cvs-relay@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).