public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@fedoraproject.org> To: cluster-cvs-relay@redhat.com Subject: gfs2-utils: master - Correction to an earlier commit. Buffers were being updated Date: Wed, 10 Jun 2009 03:10:00 -0000 [thread overview] Message-ID: <20090610030954.3252D12030C@lists.fedorahosted.org> (raw) Gitweb: http://git.fedorahosted.org/git/gfs2-utils.git?p=gfs2-utils.git;a=commitdiff;h=7e624dfed376ba265b214b699144a9d8ef081751 Commit: 7e624dfed376ba265b214b699144a9d8ef081751 Parent: 6eb36495192b073d0b8942882ef62d573b77e7b9 Author: Bob Peterson <rpeterso@redhat.com> AuthorDate: Tue Jun 9 22:05:53 2009 -0500 Committer: Bob Peterson <rpeterso@redhat.com> CommitterDate: Tue Jun 9 22:05:53 2009 -0500 Correction to an earlier commit. Buffers were being updated when they should not have been. Therefore, fsck -n would fail. --- gfs2/libgfs2/buf.c | 2 +- gfs2/libgfs2/fs_ops.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gfs2/libgfs2/buf.c b/gfs2/libgfs2/buf.c index 88f9326..f0164b4 100644 --- a/gfs2/libgfs2/buf.c +++ b/gfs2/libgfs2/buf.c @@ -176,7 +176,7 @@ void brelse(struct gfs2_buffer_head *bh, enum update_flags is_updated) { /* We can't just say b_changed = updated because we don't want to */ /* set it FALSE if it's TRUE until we write the changed data to disk. */ - if (updated) + if (is_updated) bh->b_changed = TRUE; if (!bh->b_count) { fprintf(stderr, "buffer count underflow for block %" PRIu64 diff --git a/gfs2/libgfs2/fs_ops.c b/gfs2/libgfs2/fs_ops.c index 633ca9e..2624c24 100644 --- a/gfs2/libgfs2/fs_ops.c +++ b/gfs2/libgfs2/fs_ops.c @@ -47,7 +47,7 @@ void inode_put(struct gfs2_inode *ip, enum update_flags is_updated) { if (is_updated) gfs2_dinode_out(&ip->i_di, ip->i_bh->b_data); - brelse(ip->i_bh, updated); + brelse(ip->i_bh, is_updated); free(ip); }
reply other threads:[~2009-06-10 3:10 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090610030954.3252D12030C@lists.fedorahosted.org \ --to=rpeterso@fedoraproject.org \ --cc=cluster-cvs-relay@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).