From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13779 invoked by alias); 10 Jun 2009 03:16:53 -0000 Received: (qmail 13772 invoked by alias); 10 Jun 2009 03:16:51 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_66,SPF_HELO_PASS X-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_66,SPF_HELO_PASS X-Spam-Check-By: sourceware.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bastion2.fedora.phx.redhat.com Subject: cluster: STABLE3 - Correction to an earlier commit. Buffers were being updated To: cluster-cvs-relay@redhat.com X-Project: Cluster Project X-Git-Module: cluster.git X-Git-Refname: refs/heads/STABLE3 X-Git-Reftype: branch X-Git-Oldrev: 3bb446618d1469aa6c1ddfd0e448401b58c5923a X-Git-Newrev: beaa8c5974aaaa016f49251cbf0e99ed166ad1db From: Bob Peterson Message-Id: <20090610031623.6331412031F@lists.fedorahosted.org> Date: Wed, 10 Jun 2009 03:16:00 -0000 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00490.txt.bz2 Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=beaa8c5974aaaa016f49251cbf0e99ed166ad1db Commit: beaa8c5974aaaa016f49251cbf0e99ed166ad1db Parent: 3bb446618d1469aa6c1ddfd0e448401b58c5923a Author: Bob Peterson AuthorDate: Tue Jun 9 22:05:53 2009 -0500 Committer: Bob Peterson CommitterDate: Tue Jun 9 22:13:49 2009 -0500 Correction to an earlier commit. Buffers were being updated when they should not have been. Therefore, fsck -n would fail. --- gfs2/libgfs2/buf.c | 2 +- gfs2/libgfs2/fs_ops.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gfs2/libgfs2/buf.c b/gfs2/libgfs2/buf.c index 88f9326..f0164b4 100644 --- a/gfs2/libgfs2/buf.c +++ b/gfs2/libgfs2/buf.c @@ -176,7 +176,7 @@ void brelse(struct gfs2_buffer_head *bh, enum update_flags is_updated) { /* We can't just say b_changed = updated because we don't want to */ /* set it FALSE if it's TRUE until we write the changed data to disk. */ - if (updated) + if (is_updated) bh->b_changed = TRUE; if (!bh->b_count) { fprintf(stderr, "buffer count underflow for block %" PRIu64 diff --git a/gfs2/libgfs2/fs_ops.c b/gfs2/libgfs2/fs_ops.c index 633ca9e..2624c24 100644 --- a/gfs2/libgfs2/fs_ops.c +++ b/gfs2/libgfs2/fs_ops.c @@ -47,7 +47,7 @@ void inode_put(struct gfs2_inode *ip, enum update_flags is_updated) { if (is_updated) gfs2_dinode_out(&ip->i_di, ip->i_bh->b_data); - brelse(ip->i_bh, updated); + brelse(ip->i_bh, is_updated); free(ip); }