public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: "Fabio M. Di Nitto" <fabbione@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: cluster: STABLE3 - cman init: fix groupd check
Date: Tue, 16 Jun 2009 09:50:00 -0000	[thread overview]
Message-ID: <20090616094947.5459912037D@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=45fbdfa2fa826d84d30fee86d6c972d965961645
Commit:        45fbdfa2fa826d84d30fee86d6c972d965961645
Parent:        d96fe096f1b9e588c92583bd64100dea206a8603
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Tue Jun 16 11:48:39 2009 +0200
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Tue Jun 16 11:48:39 2009 +0200

cman init: fix groupd check

groupd was not started with groupd_compat="1" because of a bad
return code in the enable check.

Fix the return code, the var check and make groupd stop conditional

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 cman/init.d/cman.in |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/cman/init.d/cman.in b/cman/init.d/cman.in
index fb12d3b..b3ceb7d 100644
--- a/cman/init.d/cman.in
+++ b/cman/init.d/cman.in
@@ -335,7 +335,8 @@ groupd_enabled()
 			2>/dev/null || true)"
 
 	[ -z "$groupd_compat" ] && return 1
-	[ "$groupd_compat" == 0 ] && return 1
+	[ "$groupd_compat" = 0 ] && return 1
+	return 0
 }
 
 cmannotifyd_enabled()
@@ -727,7 +728,7 @@ stop()
 		"Stopping fenced"
 
 	runwrap stop_groupd \
-		none \
+		groupd_enabled \
 		"Stopping groupd"
 
 	runwrap stop_qdiskd \


                 reply	other threads:[~2009-06-16  9:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090616094947.5459912037D@lists.fedorahosted.org \
    --to=fabbione@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).