public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: Lon Hohberger <lon@fedoraproject.org> To: cluster-cvs-relay@redhat.com Subject: cluster: STABLE3 - rgmanager: Fix leaked context on queue fail Date: Mon, 22 Jun 2009 13:34:00 -0000 [thread overview] Message-ID: <20090622133327.A48421201EF@lists.fedorahosted.org> (raw) Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=6a9c8dbb44439d57a9da92990619a1d47c081136 Commit: 6a9c8dbb44439d57a9da92990619a1d47c081136 Parent: ecabf4059c7a731ca3cd154647c104660e3b649f Author: Lon Hohberger <lhh@redhat.com> AuthorDate: Fri Jun 19 17:02:53 2009 -0400 Committer: Lon Hohberger <lhh@redhat.com> CommitterDate: Mon Jun 22 09:32:03 2009 -0400 rgmanager: Fix leaked context on queue fail Signed-off-by: Lon Hohberger <lhh@redhat.com> --- rgmanager/src/daemons/main.c | 19 ++++++++++++++----- 1 files changed, 14 insertions(+), 5 deletions(-) diff --git a/rgmanager/src/daemons/main.c b/rgmanager/src/daemons/main.c index 4082743..8f9fc2f 100644 --- a/rgmanager/src/daemons/main.c +++ b/rgmanager/src/daemons/main.c @@ -458,11 +458,20 @@ dispatch_msg(msgctx_t *ctx, int nodeid, int need_close) /* Distributed processing and/or request is from master node -- Queue request */ - rt_enqueue_request(msg_sm->sm_data.d_svcName, - msg_sm->sm_data.d_action, - ctx, 0, msg_sm->sm_data.d_svcOwner, - msg_sm->sm_hdr.gh_arg1, - msg_sm->sm_hdr.gh_arg2); + if (rt_enqueue_request(msg_sm->sm_data.d_svcName, + msg_sm->sm_data.d_action, + ctx, 0, msg_sm->sm_data.d_svcOwner, + msg_sm->sm_hdr.gh_arg1, + msg_sm->sm_hdr.gh_arg2) != 0) { + + /* Clean up this context if we fail to + * queue the request. */ + send_ret(ctx, msg_sm->sm_data.d_svcName, + RG_EAGAIN, msg_sm->sm_data.d_action, 0); + need_close = 1; + ret = 0; + goto out; + } return 0; case RG_EVENT:
reply other threads:[~2009-06-22 13:34 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090622133327.A48421201EF@lists.fedorahosted.org \ --to=lon@fedoraproject.org \ --cc=cluster-cvs-relay@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).